Fix log at =0.4.8 #721
Closed
Fix log at =0.4.8 #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes `log` dependency of `fuzzing` crate at `=0.4.8` since starting with the latest `log` release of `0.4.10`, there has been introduced a potential behaviour regression which made named formatting arguments illegal in log macros.
|
Hm is this perhaps a missing lock file in the repo, or perhaps something missing from the general workspace? Otherwise would it be possible to patch the source instead of locking the dependency? (assuming it's relatively easy to stay compatible with the latest release) |
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Dec 16, 2019
This'll help us track dependencies and head off issues like bytecodealliance#721
|
I've posted #726 which I think should solve the same issue, ensuring we've got a lock file for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes
logdependency offuzzingcrate at=0.4.8since starting with the latestlogrelease of0.4.10, there has been introduced a potential behaviour regression which made named formatting arguments illegal in log macros.Tracking issue: rust-lang/log#372
This should make our CI green again.