wasi-nn: update upstream specification #6853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the temporary `*.wit` files and bumps the `spec` directory to the latest [wasi-nn] commit. This is now possible because the upstream `spec` repository has all of the updated WIT and WITX bits. The `load_by_name` implementations are left as TODOs for now and will be included in a subsequent PR. One other change is a refactoring: we wrap up some types--`Graph` and `ExecutionContext`--to avoid passing around `Box<dyn ...>`. This simplifies some of the code but should not change behavior. Run all tests: prtest:full [wasi-nn]: https://github.com/WebAssembly/wasi-nn.
abrown
requested review from
jameysharp and
pchickey
and removed request for
a team
pchickey
approved these changes
Aug 16, 2023
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Aug 18, 2023
This change removes the temporary `*.wit` files and bumps the `spec` directory to the latest [wasi-nn] commit. This is now possible because the upstream `spec` repository has all of the updated WIT and WITX bits. The `load_by_name` implementations are left as TODOs for now and will be included in a subsequent PR. One other change is a refactoring: we wrap up some types--`Graph` and `ExecutionContext`--to avoid passing around `Box<dyn ...>`. This simplifies some of the code but should not change behavior. Run all tests: prtest:full [wasi-nn]: https://github.com/WebAssembly/wasi-nn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the temporary
*.witfiles and bumps thespecdirectory to the latest wasi-nn commit. This is now possible because the upstreamspecrepository has all of the updated WIT and WITX bits. Theload_by_nameimplementations are left as TODOs for now and will be included in a subsequent PR.One other change is a refactoring: we wrap up some types--
GraphandExecutionContext--to avoid passing aroundBox<dyn ...>. This simplifies some of the code but should not change behavior.