fuzzgen: Enable bitcast instruction
#6747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonso360
commented
Jul 18, 2023
Comment on lines
-457
to
+471
| let ret = args[0]; | ||
| let ret = rets[0]; | ||
|
|
||
| // Vector arguments must produce vector results, and scalar arguments must produce | ||
| // scalar results. | ||
| if arg.is_vector() != ret.is_vector() { | ||
| return false; | ||
| } | ||
|
|
||
| if arg.is_vector() && arg.is_vector() { | ||
| if arg.is_vector() && ret.is_vector() { |
There was a problem hiding this comment.
This is a little bit of a driveby fix, but these looked wrong. I ran fuzzgen afterwards and it didn't reveal any new panics.
github-actions
bot
added
the
cranelift
alexcrichton
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR enables the
bitcastinstruction in fuzzgen. This was previously fixed in #6379, and we can now start fuzzing it.