Allow WASI preopen file descriptors to be closed. #5828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Early on in WASI, we weren't sure whether we should allow preopens to be closed, so conservatively, we disallowed them. Among other things, this protected assumptions in wasi-libc that it can hold onto preopen file descriptors and rely on them always being open. However now, I think it makes sense to relax this restriction. wasi-libc itself doesn't expose the preopen file descriptors, so users shouldn't ever be closing them naively, unless they have wild closes. And toolchains other than wasi-libc may want to close preopens as a way to drop priveleges once the main file handles are opened.
Subscribe to Label Actioncc @kubkon
This issue or pull request has been labeled: "wasi"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
pchickey
approved these changes
Feb 20, 2023
sunfishcode
added a commit
to bytecodealliance/preview2-prototyping
that referenced
this pull request
Feb 25, 2023
This ports the test updates from bytecodealliance/wasmtime#5828 to the preview2-prototype and implements the ability to close preopened file descriptors.
sunfishcode
added a commit
to bytecodealliance/preview2-prototyping
that referenced
this pull request
Feb 25, 2023
This ports the test updates from bytecodealliance/wasmtime#5828 to the preview2-prototype and implements the ability to close preopened file descriptors.
sunfishcode
added a commit
to bytecodealliance/preview2-prototyping
that referenced
this pull request
Feb 27, 2023
* Allow preopen file descriptors to be closed. This ports the test updates from bytecodealliance/wasmtime#5828 to the preview2-prototype and implements the ability to close preopened file descriptors. * Fix compilation on Windows.
pchickey
pushed a commit
to pchickey/wasmtime
that referenced
this pull request
May 16, 2023
* Allow preopen file descriptors to be closed. This ports the test updates from bytecodealliance#5828 to the preview2-prototype and implements the ability to close preopened file descriptors. * Fix compilation on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early on in WASI, we weren't sure whether we should allow preopens to be closed, so conservatively, we disallowed them. Among other things, this protected assumptions in wasi-libc that it can hold onto preopen file descriptors and rely on them always being open.
However now, I think it makes sense to relax this restriction. wasi-libc itself doesn't expose the preopen file descriptors, so users shouldn't ever be closing them naively, unless they have wild closes. And toolchains other than wasi-libc may want to close preopens as a way to drop priveleges once the main file handles are opened.