wasmtime: Add FreeBSD x86 check CI Job #5506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this get lumped into the generic "Check" job? That I think would help avoid stressing github actions too much with lots of parallelism. (and it looks like the total runtime here is quite small at just over a minute) |
We accidentally broke the build for FreeBSD when introducing the jit-icache-coherence crate. To avoid this happening again, add a check job just to ensure that it can build. See bytecodealliance#5323 and bytecodealliance#5331 for context.
alexcrichton
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
We accidentally broke the build for FreeBSD when introducing the jit-icache-coherence crate. To avoid this happening again, add a check job just to ensure that it can build.
See #5323 and #5331 for context.