Flush icache on android aarch64 and unbreak Android compilation #5362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for including #5323 too! |
|
Would you also be up for adding some release notes here and sending that to |
alexcrichton
approved these changes
Dec 1, 2022
|
Ah I'll take care of that in #5363 |
|
I'll note though that Android/FreeBSD aren't officially supported platforms or don't have CI in any way. This sort of breakage is bound to continue happening and it would be best I think if we didn't have to do point releases after-the-fact. If @bnjbvr or others would be willing to at least add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #5331 in the 3.0.0 branch, and it unblocks compiling on Android and FreeBSD.