Add a wasmtime::component::bindgen! macro
#5317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscribe to Label Actioncc @kubkon
This issue or pull request has been labeled: "wasi"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
|
Of particular note, I've added |
alexcrichton
added a commit
to alexcrichton/witx-bindgen
that referenced
this pull request
Nov 22, 2022
This bindings generator has been moved to the `wasmtime` crate upstream as part of bytecodealliance/wasmtime#5317. This is another step along the road of bytecodealliance#395. The Wasmtime-hosted tests are all removed here as well but may get re-added in the future for testing as necessary.
This was referenced Nov 22, 2022
alexcrichton
added a commit
to alexcrichton/witx-bindgen
that referenced
this pull request
Nov 29, 2022
This bindings generator has been moved to the `wasmtime` crate upstream as part of bytecodealliance/wasmtime#5317. This is another step along the road of bytecodealliance#395. The Wasmtime-hosted tests are all removed here as well but may get re-added in the future for testing as necessary.
alexcrichton
force-pushed
the
merge-wit-bindgen
branch
2 times, most recently
from
db022c5 to
d2e6ccc
Compare
github-actions
bot
added
the
wasmtime:api
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This commit imports the `wit-bindgen-gen-host-wasmtime-rust` crate from the `wit-bindgen` repository into the upstream Wasmtime repository. I've chosen to not import the full history here since the crate is relatively small and doesn't have a ton of complexity. While the history of the crate is quite long the current iteration of the crate's history is relatively short so there's not a ton of import there anyway. The thinking is that this can now continue to evolve in-tree.
Make room for a `wit_bindgen` macro to slot in.
alexcrichton
force-pushed
the
merge-wit-bindgen
branch
from
d2e6ccc to
85d70a1
Compare
pchickey
approved these changes
Dec 6, 2022
alexcrichton
added a commit
to bytecodealliance/wit-bindgen
that referenced
this pull request
Dec 6, 2022
This bindings generator has been moved to the `wasmtime` crate upstream as part of bytecodealliance/wasmtime#5317. This is another step along the road of #395. The Wasmtime-hosted tests are all removed here as well but may get re-added in the future for testing as necessary.
rvolosatovs
pushed a commit
to bytecodealliance/wrpc
that referenced
this pull request
May 23, 2024
This bindings generator has been moved to the `wasmtime` crate upstream as part of bytecodealliance/wasmtime#5317. This is another step along the road of #395. The Wasmtime-hosted tests are all removed here as well but may get re-added in the future for testing as necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents merging the
wit-bindgen-gen-host-wasmtime-rustcrate from thewit-bindgenrepository into this repository. This is made possible by recent infrastructural work around movement of the dependencies involved here, and this is the final process of extracting the macro to this repository. This commit creates abindgen!macro in thewasmtime::componentsubmodule. which is thewit_bindgen_host_wasmtime_rust::generatemacro, more-or-less.A new
crates/wit-bindgenfolder is created here with awasmtime-wit-bindgencrate which is the current contents of the generation in thewit-bindgenrepsitory. I opted to not merge the full history here since recent revisions by Pat have removed most of the historical support of lifting/lowering/async/etc so the history isn't really all that interesting. Additionally parts of thewit-bindgen-coreand various other crates were merged in here and adapted to just work for this wasmtime generator.This is intended to be the "final" interface for how developers will work with
*.witfiles and Wasmtime. Thisbindgen!macro takes in a*.witfile and will, hopefully, forevermore be how this all works. This is all included in thewasmtimecrate when thecomponent-modelfeature is enabled. Further development of this macro is expected to happen in this repository, not externally. I'll in short order delete the sources in thewit-bindgenrepository in favor of the sources here.Tests have been migrated here, mostly the
codegenones. Otherwise though the component model is already thoroughly tested so theruntime/*/host.rstests were not migrated. A few small ones have been added to ensure that the generated structure works but otherwise testing is largely left to the already tested embedding API.