cranelift: Add iadd_cout lowerings for aarch64
#5177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonso360
commented
Nov 2, 2022
github-actions
bot
added
cranelift
fitzgen
reviewed
Nov 15, 2022
afonso360
force-pushed
the
aarch64-cout
branch
from
63bf792 to
1a8a631
Compare
|
I'm going to leave the i128 lowerings for a follow up PR. I've left the i128 tests in as they are useful for the interpreter. |
fitzgen
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR adds lowerings for
iadd_couton the aarch64 backend.It's based on #5176 since it found an existing bug with the interpreter. But I've opened that as a separate PR so that its easier to review.
It also adds
iadd_coutin the fuzzer and has been fuzzing for the past hour without issues.