wasmtime-component-macro: struct and consts created for flags! must be pub #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchickey
force-pushed
the
pch/component_flags_pub
branch
from
d35ce63 to
dab3789
Compare
pchickey
changed the title
alexcrichton
approved these changes
Oct 7, 2022
pchickey
force-pushed
the
pch/component_flags_pub
branch
from
5c4edb7 to
96ed12e
Compare
pchickey
force-pushed
the
pch/component_flags_pub
branch
from
96ed12e to
4762cdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this created a private type, and private consts.
I also added
fn all() -> Selfandfn empty() -> Selfconstructors, because those are the two "most popular" functions frombitflagsI stole for the sake of some tests. empty ends up being the same as Default, and all is.empty().not(), so these don't require any actual code generation.Future work might consider adding the rest of the bitflags methods & impls, and putting the docs through the macro into rustdocs.