-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some more audits for my own crates #4837
Conversation
cc @bholley |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like "arbitrary" is consistently typo'd, which I assume is why there aren't corresponding exemptions being removed. Perhaps a problem for peeking_take_while as well?
428f556
to
6c32ae9
Compare
Good catch, thanks. We don't use I think maybe the reason that the |
6c32ae9
to
346f4f6
Compare
Yeah, I added audits for the earlier versions and the exemptions go away now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that would explain it. It might be nice to add audits for the versions we're currently using as well, but seems okay without too.
Yep, done. |
Thanks!
My general recommendation for this situation (which we've run into as well) is to add an audit both for the latest version as well as the older version in tree. And yes this PR should cover the ones Firefox is using, though while you're at it you might consider some of the other crates you own that have download stats in the millions. |
Mostly stuff that Firefox is using and asked me to publish audits for, but a couple are in our dep tree as well.
346f4f6
to
18a03e1
Compare
Mostly stuff that Firefox is using and asked me to publish audits for, but a couple are in our dep tree as well.