Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cranelift AArch64: Fix the atomic memory operations #4831

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Cranelift AArch64: Fix the atomic memory operations #4831

merged 2 commits into from
Sep 2, 2022

Conversation

akirilov-arm
Copy link
Contributor

Previously the implementations of the various atomic memory IR operations ignored the memory operation flags that were passed.

@akirilov-arm
Cranelift AArch64: Fix the atomic memory operations
63ff7d5 
Previously the implementations of the various atomic memory IR operations
ignored the memory operation flags that were passed.

Copyright (c) 2022, Arm Limited.
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:aarch64 Issues related to AArch64 backend. labels Aug 31, 2022
cfallin
cfallin approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think removing the notion of sinking atomic loads is probably the right call as well. Thanks!

@cfallin
Copy link
Member

cfallin commented Sep 2, 2022

Merged upstream into this PR after merge conflicts with #4830.

@cfallin cfallin enabled auto-merge (squash) September 2, 2022 00:02
@cfallin cfallin disabled auto-merge September 2, 2022 00:03
@cfallin
Copy link
Member

cfallin commented Sep 2, 2022

(Actually disabling auto-merge here as I won't be around when it goes in and letting two run in parallel is risky; I'll merge this tomorrow.)

@akirilov-arm
Copy link
Contributor Author

We still have the rule to sink an atomic load, it's just that the helper data structure and functions were unnecessary, save for a bit of ISLE code.

@cfallin
Copy link
Member

cfallin commented Sep 2, 2022

We still have the rule to sink an atomic load, it's just that the helper data structure and functions were unnecessary, save for a bit of ISLE code.

Ah, yes, I missed that but see it now, for the (uextend (atomic_load ...)) case. Thanks!

@cfallin cfallin merged commit 48bf078 into bytecodealliance:main Sep 2, 2022
@akirilov-arm akirilov-arm deleted the aarch64_atomics branch September 2, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfallin cfallin cfallin approved these changes

Assignees
No one assigned
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akirilov-arm @cfallin