-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decrease default wasm stack to 512k from 1M #3861
Decrease default wasm stack to 512k from 1M #3861
Conversation
This commit aims to achieve the goal of being able to run the test suite on Windows with `--test-threads 1`, or more notably allowing Wasmtime's defaults to work better with the main thread on Windows which appears to have a smaller stack by default than Linux by comparison. In decreasing the default wasm stack size a test is also update to probe for less stack to work on Windows' main thread by default, ideally allowing the full test suite to work with `--test-threads 1` (although this isn't added to CI as it's not really critical). Closes bytecodealliance#3857
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
To modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me -- the stack size is "arbitrary" by default anyway as the size of stack frames is implementation-defined.
In practice of course downstream consumers may want to alter the size now if they had been silently relying on the old default... would you mind adding a note to that effect in the running release-notes doc?
(I know we both should do this eagerly for many more changes besides this one, and also we would probably note this anyway when looking over committed changes before the next release, but want to be extra-sure this one is noted)
Sounds good to me! I opened that up at #3862 as I figured I might as well go ahead and document everything else as well. |
This test is disabled on Windows because we determined it is too risky to back port #3861 to the 0.34.x release branch.
* Bump Wasmtime to 0.34.2 [automatically-tag-and-release-this-commit] * Add release notes for 0.34.2 * Disable stack overflow tests on Windows This test is disabled on Windows because we determined it is too risky to back port #3861 to the 0.34.x release branch. * Switch back to windows-2019 on CI (#3854) Looks like windows-2022 is failing, let's perhaps pin for now? Co-authored-by: Wasmtime Publish <[email protected]> Co-authored-by: Nick Fitzgerald <[email protected]> Co-authored-by: Alex Crichton <[email protected]>
This commit aims to achieve the goal of being able to run the test suite
on Windows with
--test-threads 1
, or more notably allowing Wasmtime'sdefaults to work better with the main thread on Windows which appears to
have a smaller stack by default than Linux by comparison. In decreasing
the default wasm stack size a test is also update to probe for less
stack to work on Windows' main thread by default, ideally allowing the
full test suite to work with
--test-threads 1
(although this isn'tadded to CI as it's not really critical).
Closes #3857