Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a much lower memory page limit for pooling allocator fuzzing. #3795

Merged

Conversation

peterhuene
Copy link
Member

This PR makes it such that the pooling allocator will be configured with a
much lower upper bound for memory pages, which will greatly reduce the
likelihood that the fuzzer memory limits will be hit from having too many
memories from too many instances committed.

This commit makes it such that the pooling allocator will be configured with a
much lower upper bound for memory pages, which will greatly reduce the
likelihood that the fuzzer memory limits will be hit from having too many
memories from too many instances committed.
@peterhuene peterhuene force-pushed the fix-pooling-fuzzing-rss branch from 7f2fae3 to ce18260 Compare February 12, 2022 03:07
@github-actions github-actions bot added the fuzzing Issues related to our fuzzing infrastructure label Feb 12, 2022
@github-actions
Copy link

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@peterhuene peterhuene requested a review from fitzgen February 12, 2022 22:50
@alexcrichton
Copy link
Member

@bors: r+

@alexcrichton
Copy link
Member

Oops wrong project...

@alexcrichton alexcrichton merged commit da53925 into bytecodealliance:main Feb 14, 2022
@peterhuene peterhuene deleted the fix-pooling-fuzzing-rss branch February 14, 2022 16:25
mpardesh pushed a commit to avanhatt/wasmtime that referenced this pull request Mar 17, 2022
…tecodealliance#3795)

This commit makes it such that the pooling allocator will be configured with a
much lower upper bound for memory pages, which will greatly reduce the
likelihood that the fuzzer memory limits will be hit from having too many
memories from too many instances committed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuzzing Issues related to our fuzzing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants