debug: Avoid underflow when scanning for landing pad bytes #2866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't really know what I'm doing here, but bear with me... This landing pad bytes scanning assumes at least 2 bytes in the given buffer, but in a local test case I was trying against, the buffer was empty, so 0 bytes, so the subtract would underflow. Just adding this guard seems to make it work-ish -- I don't get full variable inspection power, but I expect that this is unrelated to my change.