Atomic hotswapping in JIT mode #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cranelift
|
Writing the GOT entries needs to be delayed until after relocations have been performed and the memory has been marked as executable for code or read only for read only data. |
@eggyal has implemented this. Thanks! |
This was referenced Apr 29, 2021
Merged
bjorn3
force-pushed
the
atomic_jit
branch
2 times, most recently
from
c51af98 to
a19695b
Compare
|
I cleaned up the PR. Ready for review. |
|
r? @abrown ? |
abrown
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
Looks OK to me but I'll defer to @sunfishcode if he has any comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May conflict with #2745 or #2750, so please merge those first.