Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fcvt_to_sint_sat (f32x4 -> i32x4) for x86 #1876

Merged
merged 3 commits into from
Jun 18, 2020

Conversation

abrown
Copy link
Contributor

@abrown abrown commented Jun 12, 2020

This is the same as #1820 without the runtime guarantee flags and with some extra documentation.

@abrown abrown requested a review from julian-seward1 June 12, 2020 22:23
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:meta Everything related to the meta-language. cranelift:wasm labels Jun 12, 2020
@github-actions
Copy link

Subscribe to Label Action

cc @bnjbvr

This issue or pull request has been labeled: "cranelift", "cranelift:meta", "cranelift:wasm"

Thus the following users have been cc'd because of the following labels:

  • bnjbvr: cranelift

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Contributor

@julian-seward1 julian-seward1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit comment With user assertions, use CVTTPS2DQ directly; seems out of date (right?) -- since the idea of user assertions has been removed here. Please update before landing!

abrown added 3 commits June 18, 2020 10:34
This reuses the `x86_cvtt2si` instruction since the packed and scalar versions seem to group together well.
Use a lengthy sequence involving CVTTPS2DQ to quiet NaNs and saturate overflow.
@abrown abrown force-pushed the f32x4-to-i32x4-slow branch from 6f62360 to 85c7b33 Compare June 18, 2020 17:35
@abrown abrown merged commit 6c05590 into bytecodealliance:master Jun 18, 2020
@abrown abrown deleted the f32x4-to-i32x4-slow branch May 17, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:meta Everything related to the meta-language. cranelift:wasm cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants