Remove should_panic assertions from wast spec tests #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `should_panic` function now that all wasm spec tests are passing on arm64 (yay!). The remaining case, SIMD, has been folded into `#[ignore]`. This should prevent tons of panics from showing up in the logs while on CI because it's likely going to be some time before SIMD for aarch64 is tackled.
cfallin
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
should_panicfunction now that all wasm spectests are passing on arm64 (yay!). The remaining case, SIMD, has been
folded into
#[ignore]. This should prevent tons of panics from showingup in the logs while on CI because it's likely going to be some time
before SIMD for aarch64 is tackled.