Don't rewrite EBUSY to EINVAL in path_rename. #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grishasobol
pushed a commit
to grishasobol/wasmtime
that referenced
this pull request
Nov 29, 2021
howjmay
pushed a commit
to howjmay/wasmtime
that referenced
this pull request
Jan 24, 2022
Before, the download-wasmtime.py script would remove build/, and add empty.go files for every architecture it has unpacked library artifacts for. Since includebuild.go mentions more than that, notably macos-aarch64 (which there are no unpacked library files), we ended up in a state where the go module couldn't be built. Now, the script will remove all regular files in build/, and re- populate the directory from the downloaded tarballs. In its final step, it drops empty.go files in all directories, even those it that did not get recreated. Fixes bytecodealliance#112. This is `find build` after running the script locally: $ find build build build/macos-aarch64 build/macos-aarch64/empty.go build/linux-x86_64 build/linux-x86_64/empty.go build/linux-x86_64/libwasmtime.a build/linux-aarch64 build/linux-aarch64/empty.go build/linux-aarch64/libwasmtime.a build/include build/include/wasmtime build/include/wasmtime/error.h build/include/wasmtime/trap.h build/include/wasmtime/config.h build/include/wasmtime/global.h build/include/wasmtime/empty.go build/include/wasmtime/memory.h build/include/wasmtime/linker.h build/include/wasmtime/table.h build/include/wasmtime/instance.h build/include/wasmtime/extern.h build/include/wasmtime/func.h build/include/wasmtime/module.h build/include/wasmtime/store.h build/include/wasmtime/val.h build/include/wasmtime.h build/include/wasi.h build/include/empty.go build/include/wasm.h build/include/doc-wasm.h build/empty.go build/macos-x86_64 build/macos-x86_64/empty.go build/macos-x86_64/libwasmtime.a build/windows-x86_64 build/windows-x86_64/empty.go build/windows-x86_64/libwasmtime.a Signed-off-by: Stephan Renatus <[email protected]>
mooori
pushed a commit
to mooori/wasmtime
that referenced
this pull request
Dec 20, 2023
Unify ZK ASM test infrastructure
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 9, 2024
Upload verification results as artifacts. This could be useful for backtesting and comparison of results over time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.