Winch: implement v128 neg and shifts for x64
#10170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
requested review from
cfallin and
pchickey
and removed request for
a team
github-actions
bot
added
wasmtime:api
MarinPostma
force-pushed
the
packed-integer-arithmetic-pt2
branch
from
815adb6 to
e89fc86
Compare
Subscribe to Label Action
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:docs", "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
cfallin
requested review from
saulecabrera
and removed request for
cfallin and
pchickey
|
Passing the review baton again to Saúl -- thanks! |
saulecabrera
approved these changes
Feb 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The failure is because in main |
|
@saulecabrera rebased |
MarinPostma
force-pushed
the
packed-integer-arithmetic-pt2
branch
from
e89fc86 to
63ac43e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements the following instructions for winch x64 backend:
i8x16.negi16x8.negi32x4.negi64x2.negi8x16.shli16x8.shli32x4.shli64x2.shli8x16.shr_si16x8.shr_si32x4.shr_si64x2.shr_si8x16.shr_ui16x8.shr_ui32x4.shr_ui64x2.shr_uOne thing that we may improve is the handling of constants: My initial implementation introduced
WellKnownaddresses, because this is how cranelift implemented shifts. I revised that later on, to keep things simple, and used the constant infrastructure already present in winch. The use of well known constant addresses may be more efficient, if we decided to use them. Happy to do that in a followup.#8093