Enable warnings if async is disabled
#10145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
wasmtime:api
pchickey
approved these changes
Jan 29, 2025
Continuation of work in bytecodealliance#10131. This required a number of organizational changes to help cut down on `#[cfg]`, notably lots of async-related pieces from `store.rs` have moved to `store/async_.rs` to avoid having lots of conditional imports. Additionally this removes all of the `#[cfg]` annotations on those methods already. Additionally the signature of `AsyncCx::block_on` was updated to be a bit more general to ideally remove the need for `Pin` but it ended up not panning out quite just yet. In the future it should be possible to remove the need for `Pin` at callsites though.
alexcrichton
force-pushed
the
no-warnings-async
branch
from
c47f8e7 to
ae1b471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of work in #10131.
This required a number of organizational changes to help cut down on
#[cfg], notably lots of async-related pieces fromstore.rshave moved tostore/async_.rsto avoid having lots of conditional imports. Additionally this removes all of the#[cfg]annotations on those methods already.Additionally the signature of
AsyncCx::block_onwas updated to be a bit more general to ideally remove the need forPinbut it ended up not panning out quite just yet. In the future it should be possible to remove the need forPinat callsites though.