Winch: implement rmw xchg for x64 #10029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
requested review from
cfallin and
pchickey
and removed request for
a team
MarinPostma
force-pushed
the
winch-x64-rmw-xchg
branch
from
2be4c3a to
0785c37
Compare
Subscribe to Label Action
This issue or pull request has been labeled: "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
|
I'll take a look at this one. |
saulecabrera
requested review from
saulecabrera
and removed request for
cfallin and
pchickey
MarinPostma
force-pushed
the
winch-x64-rmw-xchg
branch
2 times, most recently
from
d36a7c9 to
01d4263
Compare
saulecabrera
approved these changes
Jan 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The failure in CI is due to a missing rebase, on top of the changes introduced in #10037 |
MarinPostma
force-pushed
the
winch-x64-rmw-xchg
branch
from
01d4263 to
edd3649
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement
xchginstructions forx64:i32.atomic.rmw8.xchg_ui32.atomic.rmw16.xchg_ui32.atomic.rmw.xchgi64.atomic.rmw8.xchg_ui64.atomic.rmw16.xchg_ui64.atomic.rmw32.xchg_ui64.atomic.rmw.xchg#9734