Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cranelift: Print and parse cold flag for blocks #3701

Closed
bjorn3 opened this issue Jan 20, 2022 · 0 comments · Fixed by #3708
Closed

Cranelift: Print and parse cold flag for blocks #3701

bjorn3 opened this issue Jan 20, 2022 · 0 comments · Fixed by #3708

Comments

@bjorn3
Copy link
Contributor

bjorn3 commented Jan 20, 2022

This flag was introduced in #3698, but round tripping between the in memory ir and textual ir format currently loses the flag.

cfallin added a commit to cfallin/wasmtime that referenced this issue Jan 20, 2022
This commit adds support for denoting cold blocks in the CLIF text
format as follows:

```plain

function %f() {
block0(...):
  ...

cold block1:
  ...

cold block2(...):
  ...

block3:
  ...
```

With this syntax, we are able to see the cold-block flag in CLIF, we can
write tests using it, and it is preserved when round-tripping.

Fixes bytecodealliance#3701.
cfallin added a commit to cfallin/wasmtime that referenced this issue Jan 21, 2022
This commit adds support for denoting cold blocks in the CLIF text
format as follows:

```plain

function %f() {
block0(...):
  ...

cold block1:
  ...

cold block2(...):
  ...

block3:
  ...
```

With this syntax, we are able to see the cold-block flag in CLIF, we can
write tests using it, and it is preserved when round-tripping.

Fixes bytecodealliance#3701.
cfallin added a commit to cfallin/wasmtime that referenced this issue Jan 21, 2022
This commit adds support for denoting cold blocks in the CLIF text
format as follows:

```plain

function %f() {
block0(...):
  ...

block1 cold:
  ...

block2(...) cold:
  ...

block3:
  ...
```

With this syntax, we are able to see the cold-block flag in CLIF, we can
write tests using it, and it is preserved when round-tripping.

Fixes bytecodealliance#3701.
alexcrichton pushed a commit to alexcrichton/wasmtime that referenced this issue Feb 2, 2022
This commit adds support for denoting cold blocks in the CLIF text
format as follows:

```plain

function %f() {
block0(...):
  ...

block1 cold:
  ...

block2(...) cold:
  ...

block3:
  ...
```

With this syntax, we are able to see the cold-block flag in CLIF, we can
write tests using it, and it is preserved when round-tripping.

Fixes bytecodealliance#3701.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant