Uncomment unwind stack frame tests that now pass on aarch64 (#4687)

Thanks to #4431 and @fitzgen who implemented it!
bytecodealliance · Aug 11, 2022 · a40b253 · a40b253
1 parent c3e31c9
commit a40b253
Showing 1 changed file with 0 additions and 11 deletions.
diff --git a/tests/all/traps.rs b/tests/all/traps.rs
@@ -30,7 +30,6 @@ fn test_trap_return() -> Result<()> {
 }
 
 #[test]
-#[cfg_attr(all(target_os = "macos", target_arch = "aarch64"), ignore)] // TODO #2808 system libunwind is broken on aarch64
 fn test_trap_trace() -> Result<()> {
     let mut store = Store::<()>::default();
     let wat = r#"
@@ -98,7 +97,6 @@ fn test_trap_backtrace_disabled() -> Result<()> {
 }
 
 #[test]
-#[cfg_attr(all(target_os = "macos", target_arch = "aarch64"), ignore)] // TODO #2808 system libunwind is broken on aarch64
 fn test_trap_trace_cb() -> Result<()> {
     let mut store = Store::<()>::default();
     let wat = r#"
@@ -133,7 +131,6 @@ fn test_trap_trace_cb() -> Result<()> {
 }
 
 #[test]
-#[cfg_attr(all(target_os = "macos", target_arch = "aarch64"), ignore)] // TODO #2808 system libunwind is broken on aarch64
 fn test_trap_stack_overflow() -> Result<()> {
     let mut store = Store::<()>::default();
     let wat = r#"
@@ -164,7 +161,6 @@ fn test_trap_stack_overflow() -> Result<()> {
 }
 
 #[test]
-#[cfg_attr(all(target_os = "macos", target_arch = "aarch64"), ignore)] // TODO #2808 system libunwind is broken on aarch64
 fn trap_display_pretty() -> Result<()> {
     let mut store = Store::<()>::default();
     let wat = r#"
@@ -199,7 +195,6 @@ wasm backtrace:
 }
 
 #[test]
-#[cfg_attr(all(target_os = "macos", target_arch = "aarch64"), ignore)] // TODO #2808 system libunwind is broken on aarch64
 fn trap_display_multi_module() -> Result<()> {
     let mut store = Store::<()>::default();
     let wat = r#"
@@ -460,7 +455,6 @@ fn call_signature_mismatch() -> Result<()> {
 }
 
 #[test]
-#[cfg_attr(all(target_os = "macos", target_arch = "aarch64"), ignore)] // TODO #2808 system libunwind is broken on aarch64
 fn start_trap_pretty() -> Result<()> {
     let mut store = Store::<()>::default();
     let wat = r#"
@@ -494,7 +488,6 @@ wasm backtrace:
 }
 
 #[test]
-#[cfg_attr(all(target_os = "macos", target_arch = "aarch64"), ignore)] // TODO #2808 system libunwind is broken on aarch64
 fn present_after_module_drop() -> Result<()> {
     let mut store = Store::<()>::default();
     let module = Module::new(store.engine(), r#"(func (export "foo") unreachable)"#)?;
@@ -579,7 +572,6 @@ fn rustc(src: &str) -> Vec<u8> {
 }
 
 #[test]
-#[cfg_attr(all(target_os = "macos", target_arch = "aarch64"), ignore)] // TODO #2808 system libunwind is broken on aarch64
 fn parse_dwarf_info() -> Result<()> {
     let wasm = rustc(
         "
@@ -624,7 +616,6 @@ fn parse_dwarf_info() -> Result<()> {
 }
 
 #[test]
-#[cfg_attr(all(target_os = "macos", target_arch = "aarch64"), ignore)] // TODO #2808 system libunwind is broken on aarch64
 fn no_hint_even_with_dwarf_info() -> Result<()> {
     let mut config = Config::new();
     config.wasm_backtrace_details(WasmBacktraceDetails::Disable);
@@ -657,7 +648,6 @@ wasm backtrace:
 }
 
 #[test]
-#[cfg_attr(all(target_os = "macos", target_arch = "aarch64"), ignore)] // TODO #2808 system libunwind is broken on aarch64
 fn hint_with_dwarf_info() -> Result<()> {
     // Skip this test if the env var is already configure, but in CI we're sure
     // to run tests without this env var configured.
@@ -722,7 +712,6 @@ fn multithreaded_traps() -> Result<()> {
 }
 
 #[test]
-#[cfg_attr(all(target_os = "macos", target_arch = "aarch64"), ignore)] // TODO #2808 system libunwind is broken on aarch64
 fn traps_without_address_map() -> Result<()> {
     let mut config = Config::new();
     config.generate_address_map(false);