fuzzing: Add a fuzz target to check that our stack traces are correct

We generate Wasm modules that keep track of their own stack as they call and
return between functions, and then we periodically check that if the host
captures a backtrace, it matches what the Wasm module has recorded.

crates/fuzzing/src/generators.rs

@@ -17,6 +17,7 @@ mod memory;
 mod module_config;
 mod single_inst_module;
 mod spec_test;
+mod stacks;
 pub mod table_ops;
 
 pub use codegen_settings::CodegenSettings;
@@ -27,3 +28,4 @@ pub use memory::{MemoryConfig, NormalMemoryConfig, UnalignedMemory, UnalignedMem
 pub use module_config::ModuleConfig;
 pub use single_inst_module::SingleInstModule;
 pub use spec_test::SpecTest;
+pub use stacks::Stacks;

crates/fuzzing/src/generators/stacks.rs

@@ -0,0 +1,327 @@
+//! Generate a Wasm program that keeps track of its current stack frames.
+//!
+//! We can then compare the stack trace we observe in Wasmtime to what the Wasm
+//! program believes its stack should be. Any discrepencies between the two
+//! points to a bug in either this test case generator or Wasmtime's stack
+//! walker.
+
+use std::mem;
+
+use arbitrary::{Arbitrary, Result, Unstructured};
+use wasm_encoder::Instruction;
+
+const MAX_FUNCS: usize = 20;
+
+/// Generate a Wasm module that keeps track of its current call stack, to
+/// compare to the host.
+#[derive(Debug)]
+pub struct Stacks {
+    funcs: Vec<Function>,
+    inputs: Vec<u8>,
+}
+
+#[derive(Debug, Default)]
+struct Function {
+    ops: Vec<Op>,
+}
+
+#[derive(Arbitrary, Debug, Clone, Copy)]
+enum Op {
+    CheckStackInHost,
+    Call(u32),
+}
+
+impl<'a> Arbitrary<'a> for Stacks {
+    fn arbitrary(u: &mut Unstructured<'a>) -> Result<Self> {
+        let funcs = Self::arbitrary_funcs(u)?;
+        let n = u.len();
+        let inputs = u.bytes(n)?.to_vec();
+        Ok(Stacks { funcs, inputs })
+    }
+}
+
+impl Stacks {
+    fn arbitrary_funcs(u: &mut Unstructured) -> Result<Vec<Function>> {
+        let mut funcs = vec![Function::default()];
+
+        // The indices of functions within `funcs` that we still need to
+        // generate.
+        let mut work_list = vec![0];
+
+        while let Some(f) = work_list.pop() {
+            let mut ops = u.arbitrary::<Vec<Op>>()?;
+            for op in &mut ops {
+                if let Op::Call(idx) = op {
+                    if u.is_empty() || funcs.len() >= MAX_FUNCS || u.ratio(4, 5)? {
+                        // Call an existing function.
+                        *idx = *idx % u32::try_from(funcs.len()).unwrap();
+                    } else {
+                        // Call a new function...
+                        *idx = u32::try_from(funcs.len()).unwrap();
+                        // ...which means we also need to eventually define it.
+                        work_list.push(funcs.len());
+                        funcs.push(Function::default());
+                    }
+                }
+            }
+            funcs[f].ops = ops;
+        }
+
+        Ok(funcs)
+    }
+
+    /// Get the input values to run the Wasm module with.
+    pub fn inputs(&self) -> &[u8] {
+        &self.inputs
+    }
+
+    /// Get this test case's Wasm module.
+    ///
+    /// The Wasm module imports a function `host.check_stack: [i32 i32] -> []`
+    /// from the host. This function is given an array (as pointer and length)
+    /// of `u32`s. This is the Wasm program's understanding of its current
+    /// stack. The host can check this against its own understanding of the Wasm
+    /// stack to find bugs.
+    ///
+    /// The Wasm module exports two functions:
+    ///
+    /// 1. `run: [i32] -> []`: This function should be called with each of the
+    ///    input values to run this generated test case.
+    ///
+    /// 2. `get_stack: [] -> [i32 i32]`: Get the pointer and length of the `u32`
+    ///    array of this Wasm's understanding of its stack. This is useful for
+    ///    checking whether the host's view of the stack at a trap matches the
+    ///    Wasm program's understanding.
+    pub fn wasm(&self) -> Vec<u8> {
+        let mut module = wasm_encoder::Module::new();
+
+        let mut types = wasm_encoder::TypeSection::new();
+        let check_stack_type = types.len();
+        types.function(
+            vec![wasm_encoder::ValType::I32, wasm_encoder::ValType::I32],
+            vec![],
+        );
+        let run_type = types.len();
+        types.function(vec![wasm_encoder::ValType::I32], vec![]);
+        let get_stack_type = types.len();
+        types.function(
+            vec![],
+            vec![wasm_encoder::ValType::I32, wasm_encoder::ValType::I32],
+        );
+        let null_type = types.len();
+        types.function(vec![], vec![]);
+        section(&mut module, types);
+
+        let mut imports = wasm_encoder::ImportSection::new();
+        let check_stack_func = 0;
+        imports.import(
+            "host",
+            "check_stack",
+            wasm_encoder::EntityType::Function(check_stack_type),
+        );
+        let num_imported_funcs = 1;
+        section(&mut module, imports);
+
+        let mut funcs = wasm_encoder::FunctionSection::new();
+        for _ in &self.funcs {
+            funcs.function(null_type);
+        }
+        let run_func = funcs.len() + num_imported_funcs;
+        funcs.function(run_type);
+        let get_stack_func = funcs.len() + num_imported_funcs;
+        funcs.function(get_stack_type);
+        section(&mut module, funcs);
+
+        let mut mems = wasm_encoder::MemorySection::new();
+        let memory = mems.len();
+        mems.memory(wasm_encoder::MemoryType {
+            minimum: 1,
+            maximum: Some(1),
+            memory64: false,
+            shared: false,
+        });
+        section(&mut module, mems);
+
+        let mut globals = wasm_encoder::GlobalSection::new();
+        let fuel_global = globals.len();
+        globals.global(
+            wasm_encoder::GlobalType {
+                val_type: wasm_encoder::ValType::I32,
+                mutable: true,
+            },
+            &Instruction::I32Const(0),
+        );
+        let stack_len_global = globals.len();
+        globals.global(
+            wasm_encoder::GlobalType {
+                val_type: wasm_encoder::ValType::I32,
+                mutable: true,
+            },
+            &Instruction::I32Const(0),
+        );
+        section(&mut module, globals);
+
+        let mut exports = wasm_encoder::ExportSection::new();
+        exports.export("run", wasm_encoder::ExportKind::Func, run_func);
+        exports.export("get_stack", wasm_encoder::ExportKind::Func, get_stack_func);
+        exports.export("memory", wasm_encoder::ExportKind::Memory, memory);
+        section(&mut module, exports);
+
+        let mut code = wasm_encoder::CodeSection::new();
+        for (func_index, func) in self.funcs.iter().enumerate() {
+            let mut body = wasm_encoder::Function::new(vec![]);
+
+            // Add this function to our internal stack.
+            //
+            // Note that we know our `stack_len_global` can't go beyond memory
+            // bounds because we limit fuel to at most `u8::MAX` and each stack
+            // entry is an `i32` and `u8::MAX * size_of(i32)` still fits in one
+            // page.
+            body.instruction(&Instruction::GlobalGet(stack_len_global))
+                .instruction(&Instruction::I32Const(
+                    (num_imported_funcs + u32::try_from(func_index).unwrap()) as i32,
+                ))
+                .instruction(&Instruction::I32Store(wasm_encoder::MemArg {
+                    offset: 0,
+                    align: 0,
+                    memory_index: memory,
+                }))
+                .instruction(&Instruction::GlobalGet(stack_len_global))
+                .instruction(&Instruction::I32Const(mem::size_of::<i32>() as i32))
+                .instruction(&Instruction::I32Add)
+                .instruction(&Instruction::GlobalSet(stack_len_global));
+
+            // Trap if we are out of fuel.
+            body.instruction(&Instruction::GlobalGet(fuel_global))
+                .instruction(&Instruction::I32Eqz)
+                .instruction(&Instruction::If(wasm_encoder::BlockType::Empty))
+                .instruction(&Instruction::Unreachable)
+                .instruction(&Instruction::End);
+
+            // Decrement fuel.
+            body.instruction(&Instruction::GlobalGet(fuel_global))
+                .instruction(&Instruction::I32Const(1))
+                .instruction(&Instruction::I32Sub)
+                .instruction(&Instruction::GlobalSet(fuel_global));
+
+            // Perform our specified operations.
+            for op in &func.ops {
+                match op {
+                    Op::CheckStackInHost => {
+                        body.instruction(&Instruction::I32Const(0))
+                            .instruction(&Instruction::GlobalGet(stack_len_global))
+                            .instruction(&Instruction::Call(check_stack_func));
+                    }
+                    Op::Call(f) => {
+                        body.instruction(&Instruction::Call(f + num_imported_funcs));
+                    }
+                }
+            }
+
+            // Remove this function from our internal stack.
+            body.instruction(&Instruction::GlobalGet(stack_len_global))
+                .instruction(&Instruction::I32Const(mem::size_of::<i32>() as i32))
+                .instruction(&Instruction::I32Sub)
+                .instruction(&Instruction::GlobalSet(stack_len_global));
+
+            body.instruction(&Instruction::End);
+            function(&mut code, body);
+        }
+
+        let mut run_body = wasm_encoder::Function::new(vec![]);
+
+        // Add the `run` function to our internal stack.
+        //
+        // See above comments about overflow.
+        run_body
+            .instruction(&Instruction::GlobalGet(stack_len_global))
+            .instruction(&Instruction::I32Const(
+                u32::try_from(run_func).unwrap() as i32
+            ))
+            .instruction(&Instruction::I32Store(wasm_encoder::MemArg {
+                offset: 0,
+                align: 0,
+                memory_index: memory,
+            }))
+            .instruction(&Instruction::GlobalGet(stack_len_global))
+            .instruction(&Instruction::I32Const(mem::size_of::<i32>() as i32))
+            .instruction(&Instruction::I32Add)
+            .instruction(&Instruction::GlobalSet(stack_len_global));
+
+        // Initialize the fuel global and call the first locally defined
+        // function.
+        run_body
+            .instruction(&Instruction::LocalGet(0))
+            .instruction(&Instruction::GlobalSet(fuel_global))
+            .instruction(&Instruction::Call(num_imported_funcs));
+
+        // Remove the `run` function from our internal stack.
+        run_body
+            .instruction(&Instruction::GlobalGet(stack_len_global))
+            .instruction(&Instruction::I32Const(mem::size_of::<i32>() as i32))
+            .instruction(&Instruction::I32Sub)
+            .instruction(&Instruction::GlobalSet(stack_len_global));
+
+        run_body.instruction(&Instruction::End);
+        function(&mut code, run_body);
+
+        let mut get_stack_body = wasm_encoder::Function::new(vec![]);
+        get_stack_body
+            .instruction(&Instruction::I32Const(0))
+            .instruction(&Instruction::GlobalGet(stack_len_global))
+            .instruction(&Instruction::End);
+        function(&mut code, get_stack_body);
+
+        section(&mut module, code);
+
+        return module.finish();
+
+        // Helper that defines a section in the module and takes ownership of it
+        // so that it is dropped and its memory reclaimed after adding it to the
+        // module.
+        fn section(module: &mut wasm_encoder::Module, section: impl wasm_encoder::Section) {
+            module.section(&section);
+        }
+
+        // Helper that defines a function body in the code section and takes
+        // ownership of it so that it is dropped and its memory reclaimed after
+        // adding it to the module.
+        fn function(code: &mut wasm_encoder::CodeSection, func: wasm_encoder::Function) {
+            code.function(&func);
+        }
+    }
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use rand::prelude::*;
+    use wasmparser::Validator;
+
+    #[test]
+    fn stacks_generates_valid_wasm_modules() {
+        let mut rng = SmallRng::seed_from_u64(0);
+        let mut buf = vec![0; 2048];
+        for _ in 0..1024 {
+            rng.fill_bytes(&mut buf);
+            let u = Unstructured::new(&buf);
+            if let Ok(stacks) = Stacks::arbitrary_take_rest(u) {
+                let wasm = stacks.wasm();
+                validate(&wasm);
+            }
+        }
+    }
+
+    fn validate(wasm: &[u8]) {
+        let mut validator = Validator::new();
+        let err = match validator.validate_all(wasm) {
+            Ok(_) => return,
+            Err(e) => e,
+        };
+        drop(std::fs::write("test.wasm", wasm));
+        if let Ok(text) = wasmprinter::print_bytes(wasm) {
+            drop(std::fs::write("test.wat", &text));
+        }
+        panic!("wasm failed to validate: {}", err);
+    }
+}

crates/fuzzing/src/oracles.rs

@@ -11,10 +11,12 @@
 //! panicking.
 
 pub mod dummy;
+mod stacks;
 
 use crate::generators;
 use arbitrary::Arbitrary;
 use log::debug;
+pub use stacks::check_stacks;
 use std::cell::Cell;
 use std::rc::Rc;
 use std::sync::atomic::{AtomicUsize, Ordering::SeqCst};