externref: Address review feedback

bytecodealliance · Jun 15, 2020 · 5019c48 · 5019c48
1 parent 618c278
commit 5019c48
Show file tree

Hide file tree

Showing 17 changed files with 388 additions and 546 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -87,6 +87,3 @@ maintenance = { status = "actively-developed" }
 [[test]]
 name = "host_segfault"
 harness = false
-
-[patch.crates-io]
-backtrace = { git = "https://github.com/rust-lang/backtrace-rs.git" }
diff --git a/crates/environ/src/cranelift.rs b/crates/environ/src/cranelift.rs
@@ -221,7 +221,7 @@ impl binemit::StackmapSink for StackMapSink {
 
 impl StackMapSink {
     fn finish(mut self) -> Vec<StackMapInformation> {
-        self.infos.sort_by_key(|info| info.code_offset);
+        self.infos.sort_unstable_by_key(|info| info.code_offset);
         self.infos
     }
 }

diff --git a/crates/jit/src/code_memory.rs b/crates/jit/src/code_memory.rs
@@ -134,7 +134,7 @@ impl CodeMemory {
 
             if !m.is_empty() {
                 unsafe {
-                    region::protect(m.as_mut_ptr(), m.len(), region::Protection::ReadExecute)
+                    region::protect(m.as_mut_ptr(), m.len(), region::Protection::READ_EXECUTE)
                 }
                 .expect("unable to make memory readonly and executable");
             }

diff --git a/crates/jit/src/instantiate.rs b/crates/jit/src/instantiate.rs
@@ -206,8 +206,8 @@ impl CompiledModule {
             signatures.into_boxed_slice(),
             host_state,
             interrupts,
-            externref_activations_table,
-            stack_map_registry,
+            &*externref_activations_table as *const _ as *mut _,
+            &*stack_map_registry as *const _ as *mut _,
         )
     }