Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm-metadata] rename Author to Authors #2052

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

yoshuawuyts
Copy link
Member

While filing bytecodealliance/wasm-pkg-tools#150 I realized the OCI annotation is called org.opencontainers.image.authors. While in wasm-metadata we called it Author. The lack of pluralization was unintentional from my part, and this PR fixes that. Thanks!

cc/ @bytecodealliance/sig-packaging

@yoshuawuyts
Copy link
Member Author

oops, hold on - submodule issues. Let me fix that.

Copy link
Contributor

@lann lann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it annoying that it is specified as plural but no guidance is given as to how to actually encode multiple authors. 🙄

Not our fault though so lgtm.

@alexcrichton alexcrichton added this pull request to the merge queue Feb 13, 2025
Merged via the queue into bytecodealliance:main with commit a86afae Feb 13, 2025
31 checks passed
@yoshuawuyts yoshuawuyts deleted the Authors branch February 14, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants