Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch cargo doc warnings in CI #1987

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

samestep
Copy link
Contributor

@samestep samestep commented Jan 27, 2025

Following up on #1986 (review). That PR fixed all warnings from cargo doc but not from cargo doc --all, so this PR fixes those too.

@samestep samestep marked this pull request as draft January 27, 2025 19:17
@samestep samestep force-pushed the cargo-doc-warnings-ci branch from b6a8923 to 9a597a9 Compare January 27, 2025 19:21
@samestep samestep marked this pull request as ready for review January 27, 2025 19:21
@pchickey
Copy link
Contributor

Thank you for working on this - we let this go for far too long and I appreciate your efforts correcting it.

@alexcrichton alexcrichton added this pull request to the merge queue Jan 27, 2025
Merged via the queue into bytecodealliance:main with commit 866672f Jan 27, 2025
30 checks passed
@samestep samestep deleted the cargo-doc-warnings-ci branch January 27, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants