Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow benchmarking just one particular compilation/instantiation/execution phase #281

Merged
merged 3 commits into from
Dec 22, 2024

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Dec 19, 2024

This avoids recompiling the Wasm module many times when we are only interested
in benchmarking instantiation or execution. Note that it is still compiled once
per process, but you can compile it exactly once if you do --processes 1.

cc @alexcrichton

…ution phase

This avoids recompiling the Wasm module many times when we are only interested
in benchmarking instantiation or execution. Note that it is still compiled once
per process, but you can compile it exactly once if you do `--processes 1`.
@fitzgen fitzgen requested a review from abrown December 19, 2024 04:09
@fitzgen
Copy link
Member Author

fitzgen commented Dec 19, 2024

Example usage that only benchmarks execution, not compilation or instantiation, and only compiles the Wasm module once:

$ sightglass-cli -e path/to/libengine.so --benchmark-phase execution --processes 1 --iterations-per-process 30

@fitzgen
Copy link
Member Author

fitzgen commented Dec 20, 2024

Needs bytecodealliance/wasmtime#9877 to land before CI will pass.

@fitzgen fitzgen merged commit 5ff7bd8 into bytecodealliance:main Dec 22, 2024
8 checks passed
@fitzgen fitzgen deleted the benchmark-particular-phases branch December 22, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants