This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Make the new Cranelift x64 backend the default. #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we keep the old backend testing in CI for a little while longer? Instead of deleting the new-backend CI jobs we can change them to be old-backend. |
After sufficient testing, we're confident that the new x64 backend does not have any correctness issues relative to the old backend; and because it generates better code, we would like to switch the default. This PR will cause `lucetc` to use the new backend by default. Building `lucetc` with the `old-x64-backend` Cargo feature will swap the old backend in again. This PR also modifies the new-backend CI tests to test the old backend instead (to ensure that it keeps working as an alternative, at least for a while).
cfallin
force-pushed
the
cfallin/new-backend-default
branch
from
d39dd1e to
fab6e75
Compare
Yes, for sure, that makes sense! Updated. |
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After sufficient testing, we're confident that the new x64 backend does
not have any correctness issues relative to the old backend; and because
it generates better code, we would like to switch the default. This PR
will cause
lucetcto use the new backend by default. Buildinglucetcwith the
old-x64-backendCargo feature will swap the old backend inagain. This PR also removes the separate new-backend CI tests.