This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
feat: oneof support for some pointer types.
#162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed CI failed by another PR |
|
I fix the CI here #167 |
bxcodec
changed the title
oneof support for some pointer types.oneof support for some pointer types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the good library.
Now I need to set
oneoffor a pointer type.(It cannot be non-ptr because it is necessary to distinguish between nil and 0)
I think this feature is in demand by users other than me, so I will create a PR.
In this PR, we becomes to be able to use other tags other than
oneofat the same time on pointer types.