Fixed instanceOf HTMLElement to work across contexts #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfdeagle47
referenced
this pull request
Jan 14, 2018
…d windows (#900) * Update AutoSizer to support using a remote window as portal render target * Create detectElementResize CSS in the window containing the rendered AutoSizer. * Create the resize trigger element using the document containing the rendered AutoSizer. * Update HTMLElement instance check to work across contexts
|
Nice catch! 😁 Verified locally. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#900 fixed an issue with iframes/child windows.
One important change was to update the HTMLElement instance check to work across contexts in AutoSizer.js.
There's still one other HTML instance check in CellMeasurer.js which was not updated to work across contexts.
This PR fixes this.