make Autosizer not pure since it always re-renders anyway because it receives children as function #1490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the suggested use of the AutoSizer is passing an inline function to it, it doesn't makes sense the AutoSizer component is pure, since it would re-render anyway:
If anybody wants to make it pure, they still can:
npm test
) all passShould i document it?
yarn run prettier
).yarn run typecheck
).Here is a short checklist of additional things to keep in mind before submitting: