Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18.1.0 not supporting #1778

Closed
SojinAntony opened this issue Oct 7, 2022 · 8 comments
Closed

React 18.1.0 not supporting #1778

SojinAntony opened this issue Oct 7, 2022 · 8 comments

Comments

@SojinAntony
Copy link

Feature Request

Package is not working with react versions 18.1.0 and greater

please update peer dependencies to
"peerDependencies": {
"react": ">=15.3.0",
"react-dom": ">=15.3.0"
},

sojinantony01 added a commit to sojinantony01/react-virtualized that referenced this issue Oct 7, 2022
@yelnyafacee
Copy link

you need npm --legacy-peer-deps

@Jephuff
Copy link

Jephuff commented Oct 19, 2022

It looks like this is fixed on main but just not deployed to npm, any chance we could get a 9.22.4 published? :)

@OnkelTem
Copy link

OnkelTem commented Nov 9, 2022

The support for React 18 was added half a year ago, and yet, there is no even an alpha version with this update?
@bvaughn, could you please clarify the situation?

@evskorobogatij
Copy link

It not working with React 18
When I try install with yarn add @types/react-virtualized@latest
I see warnings in logs
warning " > [email protected]" has incorrect peer dependency "react-dom@^15.3.0 || ^16.0.0-alpha".

And I installing yarn add @types/react-virtualized@latest --dev

'MultiGrid' cannot be used as a JSX component. Its instance type 'MultiGrid' is not a valid JSX element. The types returned by 'render()' are incompatible between these types. Type 'import("C:/app/booking-front-react/node_modules/@types/react-virtualized/node_modules/@types/react/index").ReactNode' is not assignable to type 'import("C:/app/booking-front-react/node_modules/@types/react-router/node_modules/@types/react/index").ReactNode'.

Why @types/react-virtualized@latest version is 9.21.21?

@artsur
Copy link

artsur commented Nov 16, 2022

I have the same problem:

 npm install react-virtualized
npm ERR! code ERESOLVE 
npm ERR! ERESOLVE unable to resolve dependency tree                          
npm ERR!                                                                     
npm ERR! While resolving: [email protected]                       
npm ERR! Found: [email protected]                                                 
npm ERR! node_modules/react                                                  
npm ERR!   react@"^18.2.0" from the root project                             
npm ERR!                                                                     
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.3.0 || ^16.0.0-alpha" from [email protected]
npm ERR! node_modules/react-virtualized
npm ERR!   react-virtualized@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps

@derwaldgeist
Copy link

It does not work with 17.x either:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR!   peer react@">=0.14.0" from @hypnosphi/[email protected]
npm ERR!   node_modules/@hypnosphi/create-react-context
npm ERR!     @hypnosphi/create-react-context@"^0.3.1" from [email protected]
npm ERR!     node_modules/react-bootstrap-typeahead/node_modules/react-popper
npm ERR!       react-popper@"^1.0.0" from [email protected]
npm ERR!       node_modules/react-bootstrap-typeahead
npm ERR!         react-bootstrap-typeahead@"^4.2.3" from the root project
npm ERR!       1 more (react-overlays)
npm ERR!   44 more (@restart/context, @restart/hooks, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.3.0 || ^16.0.0-alpha" from [email protected]
npm ERR! node_modules/react-virtualized
npm ERR!   react-virtualized@"^9.22.3" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/react
npm ERR!   peer react@"^15.3.0 || ^16.0.0-alpha" from [email protected]
npm ERR!   node_modules/react-virtualized
npm ERR!     react-virtualized@"^9.22.3" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/tom/.npm/eresolve-report.txt for a full report.

@memogarrido
Copy link

#1775

@bvaughn
Copy link
Owner

bvaughn commented Apr 9, 2023

Version 9.22.4 has been published with peer dependencies updated to include React 17 and 18. (No other changes from 9.22.3)

https://github.com/bvaughn/react-virtualized/releases/tag/v9.22.4

@bvaughn bvaughn closed this as completed Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants