Adds eslint + fixes linting errors 🧞‍♂️

bustle · May 29, 2020 · 2ecfd5c · 2ecfd5c
1 parent 2a3472a
commit 2ecfd5c
Show file tree

Hide file tree

Showing 10 changed files with 972 additions and 302 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
diff --git a/package.json b/package.json
@@ -12,7 +12,8 @@
   "scripts": {
     "start": "rollup -c --watch",
     "test:ci": "yarn build:docs && yarn build && testem ci -f testem-ci.js",
-    "test": "yarn format && yarn build && testem ci -f testem.js",
+    "test": "yarn lint && yarn build && testem ci -f testem.js",
+    "lint": "prettier src --check && eslint src",
     "format": "prettier src --write",
     "build": "rollup -c",
     "build:docs": "jsdoc -c ./.jsdoc",
@@ -51,6 +52,8 @@
     "@rollup/plugin-commonjs": "^11.1.0",
     "@rollup/plugin-node-resolve": "^7.1.3",
     "conventional-changelog-cli": "^2.0.34",
+    "eslint": "^7.1.0",
+    "eslint-config-prettier": "^6.11.0",
     "jquery": "^3.5.1",
     "jsdoc": "^3.6.4",
     "prettier": "^2.0.5",

diff --git a/src/js/models/_section.js b/src/js/models/_section.js
@@ -37,6 +37,7 @@ export default class Section extends LinkedItem {
     return 0
   }
 
+  // eslint-disable-next-line getter-return
   get isBlank() {
     unimplementedMethod('isBlank', this)
   }

diff --git a/src/js/parsers/dom.js b/src/js/parsers/dom.js
@@ -8,7 +8,7 @@ import { ZWNJ } from 'mobiledoc-kit/renderers/editor-dom'
 import SectionParser from 'mobiledoc-kit/parsers/section'
 import Markup from 'mobiledoc-kit/models/markup'
 
-const GOOGLE_DOCS_CONTAINER_ID_REGEX = /^docs\-internal\-guid/
+const GOOGLE_DOCS_CONTAINER_ID_REGEX = /^docs-internal-guid/
 
 const NO_BREAK_SPACE_REGEX = new RegExp(NO_BREAK_SPACE, 'g')
 const TAB_CHARACTER_REGEX = new RegExp(TAB_CHARACTER, 'g')

diff --git a/src/js/utils/cursor/position.js b/src/js/utils/cursor/position.js
@@ -10,6 +10,7 @@ const { FORWARD, BACKWARD } = DIRECTION
 
 // generated via http://xregexp.com/ to cover chars that \w misses
 // (new XRegExp('\\p{Alphabetic}|[0-9]|_|:')).toString()
+// eslint-disable-next-line no-misleading-character-class
 const WORD_CHAR_REGEX = /[A-Za-zªµºÀ-ÖØ-öø-ˁˆ-ˑˠ-ˤˬˮͅͰ-ʹͶͷͺ-ͽͿΆΈ-ΊΌΎ-ΡΣ-ϵϷ-ҁҊ-ԯԱ-Ֆՙա-ևְ-ׇֽֿׁׂׅׄא-תװ-ײؐ-ؚؠ-ٗٙ-ٟٮ-ۓە-ۜۡ-ۭۨ-ۯۺ-ۼۿܐ-ܿݍ-ޱߊ-ߪߴߵߺࠀ-ࠗࠚ-ࠬࡀ-ࡘࢠ-ࢴࣣ-ࣰࣩ-ऻऽ-ौॎ-ॐॕ-ॣॱ-ঃঅ-ঌএঐও-নপ-রলশ-হঽ-ৄেৈোৌৎৗড়ঢ়য়-ৣৰৱਁ-ਃਅ-ਊਏਐਓ-ਨਪ-ਰਲਲ਼ਵਸ਼ਸਹਾ-ੂੇੈੋੌੑਖ਼-ੜਫ਼ੰ-ੵઁ-ઃઅ-ઍએ-ઑઓ-નપ-રલળવ-હઽ-ૅે-ૉોૌૐૠ-ૣૹଁ-ଃଅ-ଌଏଐଓ-ନପ-ରଲଳଵ-ହଽ-ୄେୈୋୌୖୗଡ଼ଢ଼ୟ-ୣୱஂஃஅ-ஊஎ-ஐஒ-கஙசஜஞடணதந-பம-ஹா-ூெ-ைொ-ௌௐௗఀ-ఃఅ-ఌఎ-ఐఒ-నప-హఽ-ౄె-ైొ-ౌౕౖౘ-ౚౠ-ౣಁ-ಃಅ-ಌಎ-ಐಒ-ನಪ-ಳವ-ಹಽ-ೄೆ-ೈೊ-ೌೕೖೞೠ-ೣೱೲഁ-ഃഅ-ഌഎ-ഐഒ-ഺഽ-ൄെ-ൈൊ-ൌൎൗൟ-ൣൺ-ൿංඃඅ-ඖක-නඳ-රලව-ෆා-ුූෘ-ෟෲෳก-ฺเ-ๆํກຂຄງຈຊຍດ-ທນ-ຟມ-ຣລວສຫອ-ູົ-ຽເ-ໄໆໍໜ-ໟༀཀ-ཇཉ-ཬཱ-ཱྀྈ-ྗྙ-ྼက-ံးျ-ဿၐ-ၢၥ-ၨၮ-ႆႎႜႝႠ-ჅჇჍა-ჺჼ-ቈቊ-ቍቐ-ቖቘቚ-ቝበ-ኈኊ-ኍነ-ኰኲ-ኵኸ-ኾዀዂ-ዅወ-ዖዘ-ጐጒ-ጕጘ-ፚ፟ᎀ-ᎏᎠ-Ᏽᏸ-ᏽᐁ-ᙬᙯ-ᙿᚁ-ᚚᚠ-ᛪᛮ-ᛸᜀ-ᜌᜎ-ᜓᜠ-ᜳᝀ-ᝓᝠ-ᝬᝮ-ᝰᝲᝳក-ឳា-ៈៗៜᠠ-ᡷᢀ-ᢪᢰ-ᣵᤀ-ᤞᤠ-ᤫᤰ-ᤸᥐ-ᥭᥰ-ᥴᦀ-ᦫᦰ-ᧉᨀ-ᨛᨠ-ᩞᩡ-ᩴᪧᬀ-ᬳᬵ-ᭃᭅ-ᭋᮀ-ᮩᮬ-ᮯᮺ-ᯥᯧ-ᯱᰀ-ᰵᱍ-ᱏᱚ-ᱽᳩ-ᳬᳮ-ᳳᳵᳶᴀ-ᶿᷧ-ᷴḀ-ἕἘ-Ἕἠ-ὅὈ-Ὅὐ-ὗὙὛὝὟ-ώᾀ-ᾴᾶ-ᾼιῂ-ῄῆ-ῌῐ-ΐῖ-Ίῠ-Ῥῲ-ῴῶ-ῼⁱⁿₐ-ₜℂℇℊ-ℓℕℙ-ℝℤΩℨK-ℭℯ-ℹℼ-ℿⅅ-ⅉⅎⅠ-ↈⒶ-ⓩⰀ-Ⱞⰰ-ⱞⱠ-ⳤⳫ-ⳮⳲⳳⴀ-ⴥⴧⴭⴰ-ⵧⵯⶀ-ⶖⶠ-ⶦⶨ-ⶮⶰ-ⶶⶸ-ⶾⷀ-ⷆⷈ-ⷎⷐ-ⷖⷘ-ⷞⷠ-ⷿⸯ々-〇〡-〩〱-〵〸-〼ぁ-ゖゝ-ゟァ-ヺー-ヿㄅ-ㄭㄱ-ㆎㆠ-ㆺㇰ-ㇿ㐀-䶵一-鿕ꀀ-ꒌꓐ-ꓽꔀ-ꘌꘐ-ꘟꘪꘫꙀ-ꙮꙴ-ꙻꙿ-ꛯꜗ-ꜟꜢ-ꞈꞋ-ꞭꞰ-ꞷꟷ-ꠁꠃ-ꠅꠇ-ꠊꠌ-ꠧꡀ-ꡳꢀ-ꣃꣲ-ꣷꣻꣽꤊ-ꤪꤰ-ꥒꥠ-ꥼꦀ-ꦲꦴ-ꦿꧏꧠ-ꧤꧦ-ꧯꧺ-ꧾꨀ-ꨶꩀ-ꩍꩠ-ꩶꩺꩾ-ꪾꫀꫂꫛ-ꫝꫠ-ꫯꫲ-ꫵꬁ-ꬆꬉ-ꬎꬑ-ꬖꬠ-ꬦꬨ-ꬮꬰ-ꭚꭜ-ꭥꭰ-ꯪ가-힣ힰ-ퟆퟋ-ퟻ豈-舘並-龎ﬀ-ﬆﬓ-ﬗיִ-ﬨשׁ-זּטּ-לּמּנּסּףּפּצּ-ﮱﯓ-ﴽﵐ-ﶏﶒ-ﷇﷰ-ﷻﹰ-ﹴﹶ-ﻼＡ-Ｚａ-ｚｦ-ﾾￂ-ￇￊ-ￏￒ-ￗￚ-ￜ]|[0-9]|_|:/
 
 function findParentSectionFromNode(renderTree, node) {
@@ -436,6 +437,7 @@ BlankPosition = class BlankPosition extends Position {
   toRange() {
     return Range.blankRange()
   }
+  // eslint-disable-next-line getter-return
   get leafSectionIndex() {
     assert('must implement get leafSectionIndex', false)
   }

diff --git a/src/js/utils/key.js b/src/js/utils/key.js
@@ -225,6 +225,8 @@ const Key = class Key {
         return this.isForwardDelete() ? DIRECTION.FORWARD : DIRECTION.BACKWARD
       case this.isHorizontalArrow():
         return this.isRightArrow() ? DIRECTION.FORWARD : DIRECTION.BACKWARD
+      default:
+        return DIRECTION.FORWARD
     }
   }
 

diff --git a/src/js/utils/merge.js b/src/js/utils/merge.js
@@ -1,3 +1,4 @@
+/* eslint-disable no-prototype-builtins */
 function mergeWithOptions(original, updates, options) {
   options = options || {}
   for (var prop in updates) {

diff --git a/src/js/utils/parse-utils.js b/src/js/utils/parse-utils.js
@@ -7,7 +7,7 @@ export const MIME_TEXT_PLAIN = 'text/plain'
 export const MIME_TEXT_HTML = 'text/html'
 export const NONSTANDARD_IE_TEXT_TYPE = 'Text'
 
-const MOBILEDOC_REGEX = new RegExp(/data\-mobiledoc='(.*?)'>/)
+const MOBILEDOC_REGEX = new RegExp(/data-mobiledoc='(.*?)'>/)
 
 /**
  * @return {Post}

diff --git a/src/js/views/tooltip.js b/src/js/views/tooltip.js
@@ -44,16 +44,16 @@ export default class Tooltip extends View {
       }, HIDE_DELAY)
     }
 
-    this.addEventListener(tooltipElement, 'mouseenter', e => {
+    this.addEventListener(tooltipElement, 'mouseenter', () => {
       clearTimeout(hideTimeout)
     })
 
-    this.addEventListener(tooltipElement, 'mouseleave', e => {
+    this.addEventListener(tooltipElement, 'mouseleave', () => {
       scheduleHide()
     })
 
-    this.addEventListener(rootElement, 'mouseover', e => {
-      let target = getEventTargetMatchingTag(options.showForTag, e.target, rootElement)
+    this.addEventListener(rootElement, 'mouseover', event => {
+      let target = getEventTargetMatchingTag(options.showForTag, event.target, rootElement)
 
       if (target && target.isContentEditable) {
         clearTimeout(hideTimeout)
@@ -63,7 +63,7 @@ export default class Tooltip extends View {
       }
     })
 
-    this.addEventListener(rootElement, 'mouseout', e => {
+    this.addEventListener(rootElement, 'mouseout', () => {
       clearTimeout(showTimeout)
       if (this.elementObserver) {
         this.elementObserver.cancel()