-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update renderer to render cards #17
Comments
15 tasks
bantic
added a commit
that referenced
this issue
Nov 19, 2015
bantic
added a commit
that referenced
this issue
Nov 19, 2015
bantic
added a commit
that referenced
this issue
Nov 19, 2015
bantic
added a commit
that referenced
this issue
Nov 19, 2015
bantic
added a commit
that referenced
this issue
Nov 19, 2015
bantic
added a commit
that referenced
this issue
Nov 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Update the dom renderer to render cards as described in bustle/mobiledoc-kit#235. Checklist copied from there:
type
,name
,render
and optionaledit
propertiestype
is validated by renderer (dom renderer cannot render 'text', e.g.)render
(oredit
) methodenv
,options
andpayload
propertiesrender
(oredit
) method is appended/concatenated by rendereronTeardown(teardownFn)
Change editor-dom renderer to clear child elements from card element on teardownconstructor
signature changes to accept options object with: cards, atoms, cardOptions, unknownCardHandler, editor (for editor-dom)render
instance method acceptsmobiledoc
argument, returnsrendered
object with 2 props:result
property (which is a dom node or string, depending)teardown
method with no args tears down rendered mobiledoc (removing dom when applicable, calling registered card teardown callbacks when applicable)unknownCardHandler
method is called whenever a renderer encounters an unknown cardThe text was updated successfully, but these errors were encountered: