fix: error thrown because didCreateEditor is called too early #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
didCreateEditor
lifecycle hook is being called inwillRender
. This is throwing an EmberError when theeditor
provided bydidCreateEditor
is used elsewhere.Reproduction
Link: https://ember-twiddle.com/4ba3fad7bcc64119fcfb324f8bf770ac
Open console to see error message.
Solution
Move the
didCreateEditor
call todidInsertElement