Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change utils/createComponentCard to create a card with display/edit modes #15

Closed
bantic opened this issue Oct 14, 2015 · 0 comments · Fixed by #17
Closed

change utils/createComponentCard to create a card with display/edit modes #15

bantic opened this issue Oct 14, 2015 · 0 comments · Fixed by #17
Assignees
@bantic

Comments

@bantic
Copy link
Contributor

bantic commented Oct 14, 2015

Currently the code to swap between display and edit modes of a card is managed by the isEditing property of content-kit-component-card and utils/createComponentCard only creates cards with a display key.

This should change to have display and edit properties that add/remove '-editor' from the card name and manage which component is shown directly. content-kit-component-card should probably be removed entirely.
@bantic bantic self-assigned this Oct 14, 2015
@bantic bantic mentioned this issue Oct 14, 2015
Merged
bantic added a commit that referenced this issue Oct 15, 2015
@bantic
yield addCardInEditMode action from {{content-kit-editor}}
8366129 
This allows adding a card that is rendered initially rendered in 'edit'
mode instead of 'display' mode.

Fixes #15

Adds tests to ensure that the data is passed to cards appropriately
and that the object reference is broken.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bantic bantic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

yield addCardInEditMode from {{content-kit-editor}} bustle/ember-mobiledoc-editor
1 participant
@bantic