fix: allow numbers and booleans as validation message "$value" tokens #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
$value
token placed in the validation message is parsed as expected only when the provided value is of type string, which results in commonly used validators with non-string values such as@MinLength
,@Min
,@MaxLength
,@Max ect
. leaving the$value
token in the validation message without replacing it. This PR relaxes the runtime typecheck performed when constructing the validation message by allowing types boolean and number (alongside string) to act as $value token replacements.Documented in issues: typestack#921, typestack#1046, also reported in the NestJS repo as nestjs/nest#6431
Issue Number: N/A
What is the new behavior?
As documented in README examples - $value tokens will be replaced in the validation error message even if the underlying value is a number or a boolean.
Does this PR introduce a breaking change?
Other information