fix nim-lang#19600 No error checking on fclose

bung87 · May 27, 2022 · 2abb57c · 2abb57c
1 parent d81edca
commit 2abb57c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/std/syncio.nim b/lib/std/syncio.nim
@@ -324,7 +324,9 @@ const
 proc close*(f: File) {.tags: [], gcsafe.} =
   ## Closes the file.
   if not f.isNil:
-    discard c_fclose(f)
+    let x = c_fclose(f)
+    if x < 0:
+      checkErr(f)
 
 proc readChar*(f: File): char {.tags: [ReadIOEffect].} =
   ## Reads a single character from the stream `f`. Should not be used in

diff --git a/tests/misc/t19600.nim b/tests/misc/t19600.nim
@@ -0,0 +1,9 @@
+discard """
+  targets: "c cpp"
+  disabled: "win"
+  disabled: "osx"
+  exitcode: 1
+  outputsub: "No space left on device"
+"""
+
+writeFile("/dev/full", "hello\n")