Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS daysOfWeek #243

Merged
merged 2 commits into from
Jun 18, 2020
Merged

iOS daysOfWeek #243

merged 2 commits into from
Jun 18, 2020

Conversation

blehr
Copy link
Contributor

@blehr blehr commented Jun 18, 2020 •
edited
Loading

@blehr blehr changed the title iOS daysOfWeek #242 iOS daysOfWeek Jun 18, 2020
nickrandolph
nickrandolph reviewed Jun 18, 2020
View reviewed changes
ios/Classes/SwiftDeviceCalendarPlugin.swift
@@ -363,7 +363,7 @@ public class SwiftDeviceCalendarPlugin: NSObject, FlutterPlugin {

var totalOccurrences: Int?
var endDate: Int64?
if(ekRecurrenceRule.recurrenceEnd?.occurrenceCount != nil) {
if(ekRecurrenceRule.recurrenceEnd?.occurrenceCount != nil && ekRecurrenceRule.recurrenceEnd?.occurrenceCount != 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change required? Is there a scenario where occurrenceCount==0 and setting totalOccurrences isn't correct?

@nickrandolph nickrandolph merged commit fe932a1 into builttoroam:develop Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrandolph nickrandolph nickrandolph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blehr @nickrandolph