Squash Merge #72
Merged
Squash Merge #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Calendar shared partial class Added Calendar android partial class Added Calendar (other platforms) partial class Added IsSupported to all platforms Added Calendar test for netstandard IsSupported
Note:: For iOS there is no Calendar Read vs Write permissions, instead they have Calendar and Reminder permissions, which are quite different. https://docs.microsoft.com/en-us/xamarin/ios/platform/eventkit I've also noticed that although their is two seperate permissions for Calendar Read/Write for Android, when looking at the settings for the app after providing it with Read/Write Access it seems to set both as active, as there is no seperation in switches.
NOTE: Currently my CalendarObjects have a blocker where they cannot pull details from iOS or Android's provided libraries.
…droid GetCalendarsAsync: - Check/Request calendar read permissions - Declare calendar instance/singleton - Request List of iOS/Android platform specific calenders - Cast to new shared List<DeviceCalendar> which obtains values for * Id - Platform specific android generally holds number ids whilst iOS uses guids * Name - Name of each calendar * IsReadOnly - Can this calendar be edited - Currently the sample app only displays the name attribute, but we could indicate read only access and ids at a later state.
Feature/permissions
…pecific calendars)
…ime, Also a modal!
Note - Might need help working out why my EventToCommandBehavior isn't working for my checkboxes.
They just use their property {getters/setters}, which I could just use but it was suggested that I use the EventToCommand approach where possible.
You can also get a modal to appear giving you extra information about an event when tapping on an item within the ListView.
…l event titles visible. altered date/time pickers to not use/need nullables. Including deleted events for the time being.
…th a calendar id and required fields.
…pocToDateTimeConverter Removal of Reminders Altered Recurrance variables to use the class RecurrancePattern (will require hooking up to database later on)
…pecific calendars)
…ime, Also a modal!
Note - Might need help working out why my EventToCommandBehavior isn't working for my checkboxes.
They just use their property {getters/setters}, which I could just use but it was suggested that I use the EventToCommand approach where possible.
You can also get a modal to appear giving you extra information about an event when tapping on an item within the ListView.
…l event titles visible. altered date/time pickers to not use/need nullables. Including deleted events for the time being.
* Cleanup permissions check for Geolocation * Return false if feature or name is null. * Ensure tests run properly on android
… Tizen Still) (xamarin#927) * Implement AppTheme for iOS/tvOS/Android/UWP (Need Tizen Still) * Added docs * Added sample * Added a test
* Fixes xamarin#990 * Update azure-pipelines.yml * Add timeout for running android tests.
* Use SharedPreferences.Editor.Apply when editing to force disk write to be asynchronous (xamarin#637) * xamarinGH-182 Color/Point/Rect/Size Extension Converters (xamarin#651) * Add extension helpers for iOS and Android * Add UWP colors and adjsut android colors. * Add UWP Point/Rect/Size * Rename and optimize! * Add tests and color helpers! * Fix unit test and add WithAlpha * Cleanup iOS as it stores it from 0-1 * Tests are all green! * Add generate-docs cmd :) * Add docs config to all :) * Additional clenaup for docs * Added some docs * Updated the mdoc target and regenerated the docs * Allow for code reuse on macOS (xamarin#665) Even though macOS is not yet officially supported, it is nice to reuse this code. macOS is exactly the same, except for this single property not supported. * xamarinGH-196 Browser Customization (xamarin#646) * Implemented xamarinGH-196 * Apply suggestions from code review: Naming Renamed incorrectly spelled variables Co-Authored-By: Mrnikbobjeff <[email protected]> * Implemented xamarinGH-196 * Browser update work as requested. Using System.Drawing.Color now * Adopted more review changes. Type forwarded. * Review changes * Made equals operator null safe, removed constructor * Add documentation and simplify the API! * Update viewmodel * Back to 7.2 * xamarinGH-676 Require To Check GPS Location is Fake Or Not In GeoLocation (xamarin#677) * Added bool IsFromMockProvider in Location class * Checkin * csproj original * Revert "csproj original" This reverts commit 6302b95. * Revert "Checkin" This reverts commit 0881e4f. * Revert "Added bool IsFromMockProvider in Location class" This reverts commit e56d940. * Revert the Xamarin.Essentials.csproj and Samples.Android.csproj to original; Adjust the property IsFromMockProvider in Location.shared and LocationExetensions. * Edited sample to show if the location is from moking provider. * Update docs * Fixes xamarin#694 (xamarin#699) * Update the mdoc to use the new minimum for VS2019 * xamarinGH-126: Finish Shake Detector API (xamarin#693) * Update CONTRIBUTING.md (xamarin#692) * xamarinGH-126 Detect Shake API (xamarin#666) * Added shaken support * name vhange * check-in * doc update * Implements the Shake API inside Accelerometer Class; Change sample to AccelorometerViewModel * Fix the sample project * Update the docs * Added Queue mechanism based off seismic with tests as well. Something is not right yet with calulating isaccelerating. * Finalize shake detection!!! * Re-generated the docs. * Fix the VM after merge * xamarinGH-704 Handle duplicate item in keychain (xamarin#705) * Update CONTRIBUTING.md (xamarin#692) * xamarin#704 if we get a duplicate item try to remove and then re-add if possible. * Initial commit Clipboard Change * Implemented Clipboard listeners on iOS, tested on android and uwp and fixed other issues related to Visual Studio for Mac and Essentials support. * Initial commit Clipboard Change * Implemented Clipboard listeners on iOS, tested on android and uwp and fixed other issues related to Visual Studio for Mac and Essentials support. * Naming fix * UI improvements * Docs update * docs update part 2 * docs tool breaking fix * reverted change to csproj
* Initial (partial) effort * Get rid of old nuget feed * New permission API * Bump tests framework * Create sample for permissions API * Add some iOS info.plist usages * Show an error on permission exception in sample * Clean up iOS permission implementation * Rename platform base permission impl So that all platforms are the same and inheritance looks the same on each * Simplify static permissions api impl * Make more permission inheritance consistent * Preserve no longer needed on android Since we are instantiating the permission types properly now, the linker is happy. * Cleanup API with C# 8 and optimize for Android 10 * Cleanup tests and samples
* Calendar Read-Only API * Return exceptions that match test case System.NotImplementedException --> Xamarin.Essentials.NotImplementedInReferenceAssemblyException (#45)
…ng uap: capabilities
…thub.com/builttoroam/Essentials into feature/bridge-naming-convention-changes
…merge-readonly-calendar
…donly-calendar xamarin essentials preperation
nickrandolph
added a commit
that referenced
this pull request
Sep 28, 2020
* Squash Merge (#72) * #67 Use int.TryParse instead of Convert.ToInt32 * #59 rename extensions to more accurately represent their purpose * #61 replace usages of .Count == 0 with !.Any() * #62 rename cursor to something more meaningful * #66 Remove not needed Deleted flag from create+update event Also don't try to set up a null event. * #68 - Avoid abbreviations where possible * whoops, missed a change. * Changes adhere to PR feedback * PR Feedback - Replace strings with const values for ease of readability and to remove confusion around + numbers * PR Feedback allow recurrence rules to be removed for existing events. * #87 ios: delete calendar event instance * #82 drop down works for setting check boxes, but need to work out other way. * Undo permission testing code * Meeting PR Feedback * Make CalendarList readonly * Rename TimeSpanExtensions more accurately --> remove unnessacary extension RoundToNearestMinutes * Started Converting to bit flag * Update to get checkboxes functioning using bitflag * Alter according to PR requirements * CalendarDayOfWeek enum/bitflag working with UI and each platform * #89 Added Ability to SetEventRecurrenceEndDate which allows stopping event recurrences going from a specific date (end recurrence rule from date) * Remove blank line causing error. * Alter Recurrences TotalOccurrences to be null so that end date dictates the rule changes * Alter strings to use consts for consistency/readability * Altered picker to be 4 checkboxes (with custom no longer being an option) Also merged my two enums into one using condition values to determine results. * Alter as per PR feedback * Remove un-necessary using statement * Altered to PR feedback * Altered to PR feedback * Convert RecurrenceDays to readonly property * Alter ForLoop to use bitflag enum checks rather than relying on int bit logic override * Remove IsNone, IsWeekday, IsWeekly, IsAllDays --> Converter * Alter IsDaily || Is Weekly || IsMonthlyOrYearly || IsYearly --> RecurrenceTypeBoolConverter * Reoganize file and remove redundancies * missed merge change. * Resolve conflicts. * Prevent android from breaking onappearing for calendarpage Co-authored-by: Nick Randolph <[email protected]>
nickrandolph
added a commit
that referenced
this pull request
Sep 29, 2020
* Squash Merge (#72) * #67 Use int.TryParse instead of Convert.ToInt32 * #59 rename extensions to more accurately represent their purpose * #61 replace usages of .Count == 0 with !.Any() * #62 rename cursor to something more meaningful * #66 Remove not needed Deleted flag from create+update event Also don't try to set up a null event. * #68 - Avoid abbreviations where possible * whoops, missed a change. * Changes adhere to PR feedback * PR Feedback - Replace strings with const values for ease of readability and to remove confusion around + numbers * PR Feedback allow recurrence rules to be removed for existing events. * #87 ios: delete calendar event instance * #82 drop down works for setting check boxes, but need to work out other way. * Undo permission testing code * Meeting PR Feedback * Make CalendarList readonly * Rename TimeSpanExtensions more accurately --> remove unnessacary extension RoundToNearestMinutes * Started Converting to bit flag * Update to get checkboxes functioning using bitflag * Alter according to PR requirements * CalendarDayOfWeek enum/bitflag working with UI and each platform * #89 Added Ability to SetEventRecurrenceEndDate which allows stopping event recurrences going from a specific date (end recurrence rule from date) * Remove blank line causing error. * Alter Recurrences TotalOccurrences to be null so that end date dictates the rule changes * Alter strings to use consts for consistency/readability * Altered picker to be 4 checkboxes (with custom no longer being an option) Also merged my two enums into one using condition values to determine results. * Alter as per PR feedback * Remove un-necessary using statement * Altered to PR feedback * Altered to PR feedback * Convert RecurrenceDays to readonly property * Alter ForLoop to use bitflag enum checks rather than relying on int bit logic override * Remove IsNone, IsWeekday, IsWeekly, IsAllDays --> Converter * Alter IsDaily || Is Weekly || IsMonthlyOrYearly || IsYearly --> RecurrenceTypeBoolConverter * Reoganize file and remove redundancies * missed merge change. * Resolve conflicts. * Prevent android from breaking onappearing for calendarpage Co-authored-by: Nick Randolph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.