Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced run image resolution #357

Merged
merged 2 commits into from
May 8, 2023
Merged

Enhanced run image resolution #357

merged 2 commits into from
May 8, 2023

Conversation

c0d1ngm0nk3y
Copy link
Contributor

@c0d1ngm0nk3y c0d1ngm0nk3y commented Feb 28, 2023 •
edited
Loading

We would like to propose some enhancement to the run image resolution.

A possible implementation: buildpacks/lifecycle#1024

@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from a team as a code owner February 28, 2023 09:27
@pbusko pbusko mentioned this pull request Feb 28, 2023
Merged
natalieparellano
natalieparellano reviewed Feb 28, 2023
View reviewed changes
@c0d1ngm0nk3y c0d1ngm0nk3y force-pushed the enhance-run-image-resolution branch from a694c3d to 6385c28 Compare March 1, 2023 07:17
@natalieparellano
Copy link
Member

@c0d1ngm0nk3y @pbusko thanks for this! Is it possible you could fix the DCO? I think you need to use Signed-off-by instead of (or in addition to) Co-authored-by.

@c0d1ngm0nk3y c0d1ngm0nk3y force-pushed the enhance-run-image-resolution branch from b15ef28 to 1066adf Compare March 1, 2023 16:06
@pbusko @c0d1ngm0nk3y
Enhanced run image resolution
538e1d0 
Co-authored-by: Ralf Pannemans <[email protected]>
Co-authored-by: Pavel Busko <[email protected]>
Signed-off-by: Ralf Pannemans <[email protected]>
@c0d1ngm0nk3y c0d1ngm0nk3y force-pushed the enhance-run-image-resolution branch from 1066adf to 988d4a1 Compare March 1, 2023 16:09
@sambhav
Copy link
Member

sambhav commented Mar 9, 2023

@natalieparellano could you help retarget this to an appropriate branch?

@natalieparellano
Copy link
Member

natalieparellano commented Mar 9, 2023 •
edited
Loading

@samj1912 sounds good. Should we be guarding this change in behavior on a Platform API version in the lifecycle? Or should this be treated more like a bug-fix and back-ported to older platforms?

@natalieparellano natalieparellano changed the base branch from main to platform/0.12 March 9, 2023 21:47
matthewrobertson
matthewrobertson reviewed Mar 10, 2023
View reviewed changes
@modulo11 @c0d1ngm0nk3y
Apply feedback on run image resolution
d3069b8 
Co-authored-by: Ralf Pannemans <[email protected]>
Signed-off-by: Ralf Pannemans <[email protected]>
@c0d1ngm0nk3y c0d1ngm0nk3y force-pushed the enhance-run-image-resolution branch from 988d4a1 to d3069b8 Compare March 14, 2023 12:24
@c0d1ngm0nk3y
Copy link
Contributor Author

What is missing for this to be merged?

@natalieparellano
Copy link
Member

I believe this now has enough votes. @buildpacks/toc any further thoughts?

@c0d1ngm0nk3y
Copy link
Contributor Author

I believe this now has enough votes. @buildpacks/toc any further thoughts?

???

@natalieparellano
Copy link
Member

natalieparellano commented May 2, 2023 •
edited
Loading

I've put this on the agenda for this week's CNB Working Group. I don't see any controversy here, but I'd like clarity on this question:

Should we be guarding this change in behavior on a Platform API version in the lifecycle? Or should this be treated more like a bug-fix and back-ported to older platforms?

@natalieparellano
Copy link
Member

Just to circle back here, the consensus from Working Group is that this should be safe to treat as a bug-fix.

@natalieparellano
Copy link
Member

Merging as this has all required approvals.

@natalieparellano natalieparellano merged commit 02112bc into buildpacks:platform/0.12 May 8, 2023
@loewenstein loewenstein mentioned this pull request Jun 13, 2023
Open
@natalieparellano natalieparellano mentioned this pull request Aug 1, 2023
Merged
@pbusko pbusko mentioned this pull request Dec 14, 2023
Merged
2 tasks
@jjbustamante jjbustamante mentioned this pull request Mar 8, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewrobertson matthewrobertson matthewrobertson left review comments

@jkutner jkutner jkutner approved these changes

@natalieparellano natalieparellano natalieparellano approved these changes

@sambhav sambhav sambhav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@c0d1ngm0nk3y @natalieparellano @sambhav @jkutner @matthewrobertson @pbusko @modulo11