Improve detector log output #975
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
==========================================
+ Coverage 64.44% 64.71% +0.28%
==========================================
Files 86 86
Lines 6171 6154 -17
==========================================
+ Hits 3976 3982 +6
+ Misses 1820 1796 -24
- Partials 375 376 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
…level Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
force-pushed
the
feature/fail-detect-log-info-level
branch
from
ed6582a to
c45e4cc
Compare
| @@ -106,7 +106,7 @@ func testDetector(t *testing.T, when spec.G, it spec.S) { | |||
| "docker", | |||
| "run", | |||
| "--rm", | |||
| "--env", "CNB_ORDER_PATH=/cnb/orders/empty_order.toml", | |||
There was a problem hiding this comment.
Empty order produces no output, so it's not a good test
|
@jabrown85 it would be awesome to get your input here (as the requestor of #283) and also because I'm a bit unsure of some of the choices I made. The implementation ended up being a tad more complicated than I initially expected. Feedback is very welcome! |
This eliminates the need for a "multi logger" Signed-off-by: Natalie Arellano <[email protected]>
|
Oof, the linux ARM runner needs to be re-created |
detector.go
Outdated
| Runs: &sync.Map{}, | ||
| MemHandler: memHandler, |
There was a problem hiding this comment.
I think we could straight up hide MemHandler and let it get built and stored in Detector. It isn't something a caller needs to send in. More of an implementation detail IMO.
There was a problem hiding this comment.
You're right... updated in 0479907
Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
force-pushed
the
feature/fail-detect-log-info-level
branch
from
0505d95 to
3f4cfa5
Compare
When detect fails, print output as info level
Resolves #967