Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/0.17.0 into main #1177

Merged
merged 13 commits into from
Aug 9, 2023
Merged

Merge release/0.17.0 into main #1177

merged 13 commits into from
Aug 9, 2023

Conversation

natalieparellano
Copy link
Member

No description provided.

joe-kimmel-vmw and others added 12 commits July 20, 2023 09:16
* timestamp logs for entry/exit for all the top-level Lifecycle package functions

Signed-off-by: Joe Kimmel <[email protected]>

fixing names

Signed-off-by: Joe Kimmel <[email protected]>

using defer to make one-liners for fun and profit

Signed-off-by: Joe Kimmel <[email protected]>

and today we thank our brave linters for preventing critical defects such as unnecessary trailing newlines from being merged. Its about time somebody thought of the children.

Signed-off-by: Joe Kimmel <[email protected]>

* be more helpful when you dont recognize the phase

Signed-off-by: Joe Kimmel <[email protected]>

---------

Signed-off-by: Joe Kimmel <[email protected]>
* Update units without updating code

Signed-off-by: Natalie Arellano <[email protected]>

* Update code

Signed-off-by: Natalie Arellano <[email protected]>

* Unpend test

Signed-off-by: Natalie Arellano <[email protected]>

* Add units for rebase without updating code

Signed-off-by: Natalie Arellano <[email protected]>

* Update rebase code

Signed-off-by: Natalie Arellano <[email protected]>

* Fix lint

Signed-off-by: Natalie Arellano <[email protected]>

* When we read the descriptor file, don't fill in "*" as a magic value as missing values are wildcard matches

Signed-off-by: Natalie Arellano <[email protected]>

* Stricter validation for rebase

Signed-off-by: Natalie Arellano <[email protected]>

---------

Signed-off-by: Natalie Arellano <[email protected]>
This is needed when extensions were used to switch (but not extend) the run image
and we need to re-read the target data from the image config.

In such cases, we don't need the run image to exist in a registry,
because we don't need a manifest for kaniko.

Signed-off-by: Natalie Arellano <[email protected]>
* Rename distributions -> distros in the buildpack spec

Signed-off-by: Natalie Arellano <[email protected]>

* Rename distributions -> distros in the platform spec

Signed-off-by: Natalie Arellano <[email protected]>

---------

Signed-off-by: Natalie Arellano <[email protected]>
…ill make HTTP requests to docker daemon (#1158)

Signed-off-by: Joe Kimmel <[email protected]>
@natalieparellano natalieparellano requested a review from a team as a code owner August 9, 2023 14:55
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1177 (095694a) into main (7001b6a) will increase coverage by 0.24%.
Report is 1 commits behind head on main.
The diff coverage is 73.69%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
+ Coverage   65.92%   66.16%   +0.24%     
==========================================
  Files          97       97              
  Lines        7132     7129       -3     
==========================================
+ Hits         4701     4716      +15     
+ Misses       2011     1993      -18     
  Partials      420      420              
Flag Coverage Δ
os_linux 65.66% <73.69%> (+0.24%) ⬆️
os_windows 58.75% <73.69%> (+0.25%) ⬆️
unit 65.66% <73.69%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@natalieparellano natalieparellano merged commit c399865 into main Aug 9, 2023
@natalieparellano natalieparellano deleted the release/0.17.0 branch August 9, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants