fix to go 1.20.5 to avoid any issues with recent breaking changes #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Kimmel <[email protected]>
joe-kimmel-vmw
force-pushed
the
release/0.17.0-rc.4
branch
from
43978c9 to
062e8da
Compare
|
Is this still needed in light of #1158? I could be wrong, but it seems the pack tests that are failing are using "copy from container" methods that the lifecycle doesn't use. |
|
I think we can close this one. https://github.com/moby/moby/releases/tag/v24.0.5 now exists and we should be bumping up to that rather than downgrading our go version... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.