-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebaser changes for run image extension #1032
Conversation
Signed-off-by: Jesse Brown <[email protected]>
For platforms >= 0.12 - the rebaser will now fail if the io.buildpacks.rebasable label is set to false when the force flag is not set. Signed-off-by: Jesse Brown <[email protected]>
For Platforms >= 0.12, the default rebase target has moved to the `runImage` key in the `io.buildpacks.lifecycle.metadata` label. This change allows the lifecycle to read the `runImage` key and use it as the default rebase target. Signed-off-by: Jesse Brown <[email protected]>
Signed-off-by: Jesse Brown <[email protected]>
Signed-off-by: Jesse Brown <[email protected]>
I think we should fall through to the stack key. Otherwise it would be hard to rebase old apps that were created before the platform was upgraded. |
I agree. Do we need a spec change then? Rebase spec doesn't say this will happen. |
Signed-off-by: Jesse Brown <[email protected]>
Sounds good. I made a code suggestion here: https://github.com/buildpacks/spec/pull/335/files#r1142221664 on buildpacks/spec#335 |
@jabrown85 this one looks fully updated - should we merge it? |
I'm happy if you are @natalieparellano! No one has reviewed it officially so go right ahead 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Open Questions
runImage
not be present, should we be failing? The spec doesn't say it allows for the fallback to the oldstack
key..but it feels aggressive to me.false
. I coded it as such, but anything other thanfalse
is treated as true. This may be unexpected.Ref: #1000