Support custom access to docker image repository #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wanjunlei <[email protected]>
There was a problem hiding this comment.
@wanjunlei thanks so much for the PR! In general this looks good to me. I added a couple comments and suggestions.
We've come across this problem before (see buildpacks/lifecycle#524) and this would take us one step closer to solving it for other components 🎉
Signed-off-by: wanjunlei <[email protected]>
There was a problem hiding this comment.
@wanjunlei thanks for updating! I left a couple more nits. But otherwise this seems good to go.
Signed-off-by: wanjunlei <[email protected]>
natalieparellano
approved these changes
Aug 5, 2022
|
Thanks for the PR @wanjunlei! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wanjunlei [email protected]
When creating a new imange, it can register a docker image registry with
WithRegistryoption like thisThe first parameter is the URL of the docker image registry, the second is whether this registry is an insecure registry, and the third is whether to skip TLS authentication. And it can register serval registries.
This is useful when using a private docker image registry, and this pr is for the lifecycle to support a private docker image registry.