Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build pod nodeSelector, Tolerations, and Affinity configurable #820

Merged
merged 4 commits into from
Sep 22, 2021

Conversation

tylerphelan
Copy link
Contributor

  • Build pods will no longer determine tolerations

fix #621

@tylerphelan tylerphelan force-pushed the build-pod-node-selection branch 2 times, most recently from 5bbfdcc to 0700500 Compare September 9, 2021 19:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #820 (5f2d43e) into main (3e978d5) will increase coverage by 0.27%.
The diff coverage is 92.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
+ Coverage   67.78%   68.06%   +0.27%     
==========================================
  Files         112      112              
  Lines        4843     4856      +13     
==========================================
+ Hits         3283     3305      +22     
+ Misses       1191     1186       -5     
+ Partials      369      365       -4     
Impacted Files Coverage Δ
pkg/apis/build/v1alpha1/image_types.go 25.00% <ø> (ø)
pkg/apis/build/v1alpha2/build_types.go 100.00% <ø> (ø)
pkg/apis/build/v1alpha2/image_types.go 50.00% <ø> (ø)
pkg/apis/build/v1alpha1/image_validation.go 97.01% <50.00%> (-2.99%) ⬇️
pkg/apis/build/v1alpha2/image_validation.go 97.43% <71.42%> (-2.57%) ⬇️
pkg/apis/build/v1alpha2/build_validation.go 81.81% <87.50%> (+0.73%) ⬆️
pkg/apis/build/v1alpha2/build_pod.go 97.14% <100.00%> (-0.03%) ⬇️
pkg/apis/build/v1alpha2/image_builds.go 67.53% <100.00%> (+6.29%) ⬆️
pkg/apis/build/v1alpha2/image_conversion.go 94.28% <100.00%> (+0.73%) ⬆️
pkg/buildpod/generator.go 65.43% <100.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e978d5...5f2d43e. Read the comment docs.

Copy link
Collaborator

@matthewmcnew matthewmcnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the open api needs to be regenerated with runtimeClassName, schedulerName

@tylerphelan tylerphelan force-pushed the build-pod-node-selection branch from 5f2d43e to 886e940 Compare September 14, 2021 19:50
@tylerphelan
Copy link
Contributor Author

It looks like the open api needs to be regenerated with runtimeClassName, schedulerName

how do I keep forgetting!

@tylerphelan tylerphelan reopened this Sep 14, 2021
@matthewmcnew
Copy link
Collaborator

matthewmcnew commented Sep 14, 2021

Let's wait until the corresponding RFC is merged #812

Tyler Phelan added 4 commits September 22, 2021 11:34
- Build pods will no longer determine tolerations

fix #621
- We don't need this data anymore as tolerations are not automatic
@tylerphelan tylerphelan force-pushed the build-pod-node-selection branch from 886e940 to 4eab06b Compare September 22, 2021 15:34
@tomkennedy513 tomkennedy513 merged commit f898857 into main Sep 22, 2021
@tomkennedy513 tomkennedy513 deleted the build-pod-node-selection branch September 22, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Run build pods on dedicated worker node
5 participants