Add support for platform API 0.6 #796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #796 +/- ##
==========================================
- Coverage 71.35% 71.25% -0.11%
==========================================
Files 117 117
Lines 5412 5420 +8
==========================================
Hits 3862 3862
- Misses 1183 1189 +6
- Partials 367 369 +2
Continue to review full report at Codecov.
|
tylerphelan
approved these changes
Aug 18, 2021
tomkennedy513
approved these changes
Aug 19, 2021
| @@ -760,10 +766,10 @@ func (b *Build) setupBindings() ([]corev1.Volume, []corev1.VolumeMount) { | |||
|
|
|||
| func (bc *BuildPodBuilderConfig) highestSupportedPlatformAPI(b *Build) (string, error) { | |||
There was a problem hiding this comment.
Could we instead have this method return a parsed platform api?
| @@ -390,12 +391,17 @@ func (b *Build) BuildPod(images BuildPodImages, secrets []corev1.Secret, taints | |||
| "-project-metadata=/layers/project-metadata.toml"}, | |||
| cacheArgs, | |||
| func() []string { | |||
| if platformAPI == "0.3" { | |||
| platformAPIVersion := semver.MustParse(platformAPI) | |||
There was a problem hiding this comment.
A bit concerned about the "MustParse" here a bad builder with an invalid metadata could lead to a panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #767