Add missing builder image labels #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mentioned as defacto labels in spec rfc https://github.com/buildpacks/rfcs/blob/main/text/0049-multi-api-lifecycle-descriptor.md Keep old metadata label for backwards compatibility - Update lifecycle descriptor schema to match spec
Codecov Report
@@ Coverage Diff @@
## main #730 +/- ##
==========================================
+ Coverage 67.57% 67.58% +0.01%
==========================================
Files 93 93
Lines 3719 3721 +2
==========================================
+ Hits 2513 2515 +2
Misses 860 860
Partials 346 346
Continue to review full report at Codecov.
|
tomkennedy513
approved these changes
Jun 15, 2021
matthewmcnew
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep old metadata label for backwards compatibility